Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable ALTER TABLE with multiple commands by default on 23.2 #108870

Closed
Xiang-Gu opened this issue Aug 16, 2023 · 0 comments · Fixed by #109818
Closed

Disable ALTER TABLE with multiple commands by default on 23.2 #108870

Xiang-Gu opened this issue Aug 16, 2023 · 0 comments · Fixed by #109818
Assignees
@Xiang-Gu
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented Aug 16, 2023 •
edited by cockroach-jira-scripts
Loading

In #99526, we supported ALTER TABLE with multiple ADD COLUMN, DROP COLUMN, ALTER PK commands in the declarative schema changer. We should disable this behavior by default for 23.2 behind a cluster setting, similar to what we did for other stmts implemented during the 23.2 development cycle (#107815)

Jira issue: CRDB-30675
@Xiang-Gu Xiang-Gu added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Aug 16, 2023
@Xiang-Gu Xiang-Gu self-assigned this Aug 16, 2023
@Xiang-Gu Xiang-Gu mentioned this issue Aug 31, 2023
Merged
@craig craig bot closed this as completed in 725501d Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xiang-Gu Xiang-Gu

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Foundations
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

schemachanger: Disable ALTER TABLE multiple commands by default Xiang-Gu/cockroach
1 participant
@Xiang-Gu