From 75082b8f92a27fd8fdaf13a6787b7a22d49a099f Mon Sep 17 00:00:00 2001
From: Akshay Joshi <akshay@cockroachlabs.com>
Date: Fri, 10 Jan 2025 06:07:58 +0000
Subject: [PATCH] lease: unredact lease struct

Previously, ID from lease was getting redacted in logs. This was creating
challenge to support team to debug issues. This change makes sure that
SafeFormat is getting invoked during logging.

Epic: CRDB-37533
Part of: CRDB-44885
Release note: None
---
 pkg/sql/catalog/lease/lease.go | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/pkg/sql/catalog/lease/lease.go b/pkg/sql/catalog/lease/lease.go
index 57070cdc35ba..ab51d4ceffc2 100644
--- a/pkg/sql/catalog/lease/lease.go
+++ b/pkg/sql/catalog/lease/lease.go
@@ -1882,7 +1882,7 @@ SELECT COALESCE(l."descID", s."desc_id") as "descID", COALESCE(l.version, s.vers
 			// Early exit?
 			row := rows[i]
 			wg.Add(1)
-			lease := storedLease{
+			lease := &storedLease{
 				id:      descpb.ID(tree.MustBeDInt(row[0])),
 				version: int(tree.MustBeDInt(row[1])),
 			}
@@ -1911,7 +1911,7 @@ SELECT COALESCE(l."descID", s."desc_id") as "descID", COALESCE(l.version, s.vers
 					WaitForSem: true,
 				},
 				func(ctx context.Context) {
-					m.storage.release(ctx, m.stopper, &lease)
+					m.storage.release(ctx, m.stopper, lease)
 					log.Infof(ctx, "released orphaned lease: %+v", lease)
 					wg.Done()
 				}); err != nil {