-
Notifications
You must be signed in to change notification settings - Fork 936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conformance results for v1.20/k0s v0.10.0 #1310
Conversation
Signed-off-by: Jussi Nummelin <[email protected]>
563b035
to
ce1d3a0
Compare
Found v1.20 in logs |
This conformance request failed to include all of the required tests for v1.20 |
The first test found to be mssing was [sig-scheduling] SchedulerPredicates [Serial] validates that there is no conflict between pods with same hostPort but different hostIP and protocol [LinuxOnly] [Conformance] |
#1308 is seeing the same thing, although in their case the validation result has changed without them changing the test result data. Feels like a bug in the bot validating the results 🤷 |
Thanks for pointing that out @jnummelin - we are looking into this and will get back to you! |
@taylorwaggoner thanks |
@jnummelin I looked at the failure message and replicated it in another repo. The error is valid and there is a miss-match between the conformance.yaml file in the K/K Master branch and the content of your junit file. This was caused by PR #98299 changing the conformance.yaml file. Your data contain the test Sorry, for the confusing error message. The message has a logic error, reporting the test that fell out and not the missing new test. (We are working on that) |
@jnummelin It seems to be a bug. |
I think we found the issue upstream. Our validation compares the tests in your logs to a curated list of tests in the main branch: A 1.16 test was changed/renamed/relocated and accidentally tagged as updated for 1.20. However it should have been update for inclusion in 1.21. @heyste created a PR to update the metadata and look forward to that being merged by #sig-scheduling, #sig-networking, and #sig-arch: I'm asking for priority here, so watch this space, and thanks for your patience. Once this merges we should be able to re-validate against the correct / updated list of tests for 1.20. |
@hh thanks for the update |
@jnummelin I believe we figured out the issue causing the failure of PR checks. |
Automatically verified as having all required tests present and passed |
Automatically verified as having all required tests present and passed |
@Riaankl thanks for addressing this, I now see all the proper labels in place. |
Signed-off-by: Jussi Nummelin <[email protected]>
Signed-off-by: Jussi Nummelin <[email protected]>
Signed-off-by: Jussi Nummelin <[email protected]>
Signed-off-by: Jussi Nummelin <[email protected]>
Signed-off-by: Jussi Nummelin [email protected]
Pre-submission checklist:
Please check each of these after submitting your pull request:
repo_url
?