Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing metadata.creationTimestamp #93

Closed
urbaniak opened this issue Nov 28, 2019 · 5 comments
Closed

Missing metadata.creationTimestamp #93

urbaniak opened this issue Nov 28, 2019 · 5 comments

Comments

@urbaniak
Copy link

Need to access creationTimestamp of pods metadata and figured out it's missing from the ObjectMeta struct.

Is it possible to add it?

@clux
Copy link
Member

clux commented Nov 28, 2019

yeah, of course! feel free to submit a pr with the 1/2 lines and i'll merge. Otherwise i'm sure there'll be a release some time this / next week.

@clux
Copy link
Member

clux commented Nov 30, 2019

Ok, had a quick go at this.

It would either introduce the dependency on:

use k8s_openapi::apimachinery::pkg::apis::meta::v1::{Time};

to decode the timestamp correctly, or we inline that same code :/

But we already use that code in the non-default feature openapi. Might just release it under the openapi feature only for now.

@clux
Copy link
Member

clux commented Nov 30, 2019

For now, have hidden it behind openapi, but might inline https://docs.rs/k8s-openapi/0.6.0/src/k8s_openapi/v1_16/apimachinery/pkg/apis/meta/v1/time.rs.html#5 in this crate in the future. We've copied the generic parts from there before.

@clux
Copy link
Member

clux commented Nov 30, 2019

Released in 0.22.0

@clux
Copy link
Member

clux commented Nov 30, 2019

For now, have hidden it behind openapi, but might inline https://docs.rs/k8s-openapi/0.6.0/src/k8s_openapi/v1_16/apimachinery/pkg/apis/meta/v1/time.rs.html#5 in this crate in the future. We've copied the generic parts from there before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants