Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading Kubeconfig fails if it contains pems with no trailing newline #504

Closed
rrichardson opened this issue Apr 29, 2021 · 0 comments · Fixed by #505
Closed

Loading Kubeconfig fails if it contains pems with no trailing newline #504

rrichardson opened this issue Apr 29, 2021 · 0 comments · Fixed by #505
Labels
bug Something isn't working config Kube config related

Comments

@rrichardson
Copy link
Contributor

X509::from_pem fails if the kubeconfig has been constructed so that the pkey or certs are missing a trailing newline. By the spec, they're supposed to have a trailing newline after the ----- END RSA PRIVATE KEY ----- but hey, stuff happens.

Kubectl tolerates this scenario, so we should ensure that kube meets those expectations.
@rrichardson rrichardson mentioned this issue Apr 29, 2021
Merged
@clux clux added bug Something isn't working config Kube config related labels Apr 29, 2021
@clux clux closed this as completed in #505 Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working config Kube config related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a newline to pem blobs if one is not present rrichardson/kube-rs
2 participants
@rrichardson @clux