Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use id-token for oidc Authentication Provider #419

Merged
merged 1 commit into from
Feb 14, 2021
Merged

Use id-token for oidc Authentication Provider #419

merged 1 commit into from
Feb 14, 2021

Conversation

twz123
Copy link
Contributor

@twz123 twz123 commented Feb 13, 2021

This basically restores the functionality that has been added in #70. Same caveats apply here: auto-refresh of expired id-token is not supported.

kazk
kazk reviewed Feb 13, 2021
View reviewed changes
Copy link
Member

@kazk kazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I had overlooked oidc support when refactoring..

Do you think you can make this fit in the existing code?

Move this in token_from_provider by adding ProviderToken::Oidc variant and matching that like gcp. If not, I can do it in a separate PR.

@twz123
Copy link
Contributor Author

twz123 commented Feb 13, 2021

Will do 👍

@twz123
Use id-token for oidc Authentication Provider
977b544 
This basically restores the functionality that has been added in kube-rs#70.
Same caveats apply here: auto-refresh of expired id-token is not
supported.
@twz123 twz123 force-pushed the use-id-token-for-oidc branch from 4821d3c to 977b544 Compare February 13, 2021 23:18
kazk
kazk approved these changes Feb 13, 2021
View reviewed changes
Copy link
Member

@kazk kazk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@clux clux merged commit 0238ee9 into kube-rs:master Feb 14, 2021
@davidB davidB mentioned this pull request Feb 17, 2021
Closed
@clux
Copy link
Member

clux commented Feb 17, 2021 •
edited
Loading

released in 0.50.1, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kazk kazk kazk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twz123 @clux @kazk