From a17434aacb55f5ff387ed1f4bb71f7669405e740 Mon Sep 17 00:00:00 2001 From: Kemal Hadimli Date: Tue, 12 Apr 2022 11:37:47 +0100 Subject: [PATCH] fix: Count diag.PANIC as error --- provider/diag/diagnostics.go | 2 +- provider/execution/execution.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/provider/diag/diagnostics.go b/provider/diag/diagnostics.go index e025a807..3f973e93 100644 --- a/provider/diag/diagnostics.go +++ b/provider/diag/diagnostics.go @@ -50,7 +50,7 @@ func (diags Diagnostics) Error() string { func (diags Diagnostics) HasErrors() bool { for _, d := range diags { - if d.Severity() == ERROR { + if d.Severity() >= ERROR { return true } } diff --git a/provider/execution/execution.go b/provider/execution/execution.go index 038d2a13..5ffe4761 100644 --- a/provider/execution/execution.go +++ b/provider/execution/execution.go @@ -343,7 +343,7 @@ func (e TableExecutor) resolveResourceValues(ctx context.Context, meta schema.Cl stack := string(debug.Stack()) e.Logger.Error("resolve table recovered from panic", "table", e.Table.Name, "panic_msg", r, "stack", stack) diags = fromError(fmt.Errorf("column resolve panic: %s", r), diag.WithResourceName(e.ResourceName), diag.WithSeverity(diag.PANIC), - diag.WithSummary("resolve table %q recovered from panic.", e.Table.Name), diag.WithDetails("%s", stack)) + diag.WithSummary("resolve table %q recovered from panic", e.Table.Name), diag.WithDetails("%s", stack)) } }()