This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
feat: Add waf/wafv2 logging config #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zagronitay
requested review from
a team and
spangenberg
and removed request for
a team
roneli
approved these changes
May 9, 2022
|
This will require a change to the AWS policy: |
Thank you for that. |
bbernays
approved these changes
May 18, 2022
yevgenypats
suggested changes
May 25, 2022
resources/services/waf/rules.go
Outdated
| Name: "aws_waf_rule_predicates", | ||
| Description: "This is AWS WAF Classic documentation", | ||
| Resolver: fetchWafRulePredicates, | ||
| Options: schema.TableCreationOptions{PrimaryKeys: []string{"rule_cq_id", "data_id"}}, |
There was a problem hiding this comment.
I think this is unneeded anymore?
There was a problem hiding this comment.
It's already removed in #921
I've rebased
bbernays
approved these changes
May 25, 2022
kodiakhq bot
pushed a commit
that referenced
this pull request
May 31, 2022
🤖 I have created a release *beep* *boop* --- ### [0.12.1](v0.12.0...v0.12.1) (2022-05-31) ### Features * Add tags for organizations.Account ([#942](#942)) ([b1a350d](b1a350d)), closes [#940](#940) * Add waf/wafv2 logging config ([#814](#814)) ([ed6c836](ed6c836)) ### Bug Fixes * Classify MetadataException ([#953](#953)) ([2b74e7b](2b74e7b)) * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.10.2 ([#951](#951)) ([b5b4c97](b5b4c97)) * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.10.3 ([#954](#954)) ([21a5818](21a5818)) * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.10.4 ([#961](#961)) ([648f6c1](648f6c1)) * **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.10.5 ([#967](#967)) ([40a1d06](40a1d06)) * Remove relation tables PK ([#921](#921)) ([036ce47](036ce47)) * Update endpoints ([#948](#948)) ([3b5b193](3b5b193)) * Update endpoints ([#952](#952)) ([c59523c](c59523c)) * Update endpoints ([#956](#956)) ([5702860](5702860)) * Update endpoints ([#958](#958)) ([df14874](df14874)) * Update timestamps fields ([#891](#891)) ([48b9e6f](48b9e6f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉
Summary
Use the following steps to ensure your PR is ready to be reviewed
go fmtto format your code 🖊go run ./docs/docs.goand committing the changes 📃