This repository has been archived by the owner on Aug 16, 2022. It is now read-only.
feat: Shield protections added #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amanenk
requested review from
a team and
shimonp21
and removed request for
a team
roneli
suggested changes
Apr 20, 2022
There was a problem hiding this comment.
Would add the following APIs
https://docs.aws.amazon.com/waf/latest/DDOSAPIReference/API_DescribeSubscription.html)
https://docs.aws.amazon.com/waf/latest/DDOSAPIReference/API_ListProtectionGroups.html
https://docs.aws.amazon.com/waf/latest/DDOSAPIReference/API_ListAttacks.html <- would fetch only last 24 hours
|
Also seems that resource missing is ShieldRegional API |
bbernays
suggested changes
May 4, 2022
amanenk
force-pushed
the
shield_protections
branch
from
74fc3dd to
cd6cd6c
Compare
bbernays
reviewed
May 4, 2022
# Conflicts: # resources/provider/migrations/postgres/29_v0.11.3.down.sql # resources/provider/migrations/postgres/29_v0.11.3.up.sql # resources/provider/migrations/timescale/29_v0.11.3.down.sql # resources/provider/migrations/timescale/29_v0.11.3.up.sql
roneli
approved these changes
May 5, 2022
# Conflicts: # resources/provider/migrations/postgres/29_v0.11.3.down.sql # resources/provider/migrations/postgres/29_v0.11.3.up.sql # resources/provider/migrations/timescale/29_v0.11.3.down.sql # resources/provider/migrations/timescale/29_v0.11.3.up.sql
amanenk
force-pushed
the
shield_protections
branch
from
f324d98 to
58107e0
Compare
# Conflicts: # resources/provider/migrations/postgres/29_v0.11.3.down.sql # resources/provider/migrations/timescale/29_v0.11.3.down.sql # resources/provider/migrations/timescale/29_v0.11.3.up.sql
amanenk
force-pushed
the
shield_protections
branch
from
61d3de4 to
86739a5
Compare
This was referenced May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shield regional is skipped cause of lack of documentation.
e2e is skipped because of high cost of infrastructure.
closes #623