Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Fix Tests #1178

Merged
merged 1 commit into from
Jul 6, 2022
Merged

fix: Fix Tests #1178

merged 1 commit into from
Jul 6, 2022

Conversation

bbernays
Copy link
Contributor

@bbernays bbernays commented Jul 6, 2022

Summary

Now that CQ binary is enforcing more checks of configuration files we need to ensure config is correct


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@bbernays bbernays requested a review from a team as a code owner July 6, 2022 19:01
@bbernays bbernays requested review from shimonp21 and removed request for a team July 6, 2022 19:01
@kodiakhq kodiakhq bot merged commit 8c4d01d into cloudquery:main Jul 6, 2022
@bbernays bbernays deleted the fix-tests branch July 6, 2022 19:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants