Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Ignore S3 Buckets Errors #1175

Merged
merged 4 commits into from
Jul 7, 2022
Merged

fix: Ignore S3 Buckets Errors #1175

merged 4 commits into from
Jul 7, 2022

Conversation

bbernays
Copy link
Contributor

@bbernays bbernays commented Jul 6, 2022

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@bbernays bbernays requested a review from a team as a code owner July 6, 2022 13:44
@bbernays bbernays requested review from yevgenypats, irmatov and disq and removed request for a team July 6, 2022 13:44
roneli
roneli approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@roneli roneli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM see my comments in #1177 regarding #1180

@kodiakhq kodiakhq bot merged commit 2907699 into cloudquery:main Jul 7, 2022
@cq-bot cq-bot mentioned this pull request Jul 7, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@disq disq disq left review comments

@roneli roneli roneli approved these changes

@yevgenypats yevgenypats yevgenypats approved these changes

@irmatov irmatov Awaiting requested review from irmatov

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bbernays @disq @yevgenypats @roneli