fix(docs): Update documentation about adding new resources

[hermanschaaf]

Some small fixes and updates to adding_a_new_resource.md for correctness.

[bbernays]

I would say it is better to set the AWS_PROFILE environment variable. That way credentials can be managed in the ~/.aws/config and can use any of credential sources like AWS_SSO, credential_process or worst case scenario hard coded credentials

[hermanschaaf]

Fair enough! I think AWS_SECRET_ACCESS_KEY is probably the easiest way to get started quickly, so it's worth mentioning we support that too. I've changed it now to recommend AWS_PROFILE, but mention that we support other methods in a comment. WDYT?

[bbernays]

I agree that we cannot not support hard coded credentials! I think that we should be helping/pushing users to follow the best practices. I like that idea of putting the link to the docs! Here is a good article about this

[yevgenypats]

We can just link to this one - https://hub.cloudquery.io/providers/cloudquery/aws/latest#authentication
This will also serve as nice cross link to our docs

[hermanschaaf]

Looks like the unit tests are failing for some unrelated reason:

--- FAIL: TestCloudwatchlogsFilter (0.05s)
    filters_mock_test.go:31: fetch resources [test_resource]
    provider.go:257: [INFO] calculated max goroutines for fetch execution [max_goroutines 65536]
    execution.go:251: [INFO] fetched successfully [count 1]
    --- FAIL: TestCloudwatchlogsFilter/aws_cloudwatchlogs_filters (0.00s)
        --- FAIL: TestCloudwatchlogsFilter/aws_cloudwatchlogs_filters/aws_cloudwatchlogs_filter_metric_transformations (0.00s)
            filters_mock_test.go:31: expected to have at least 1 entry at table aws_cloudwatchlogs_filter_metric_transformations got zero
FAIL
FAIL	github.com/cloudquery/cq-provider-aws/resources/services/cloudwatchlogs	0.072s

@yevgenypats or @bbernays do you happen to know something about this? Otherwise I can investigate

[bbernays]

Looks like the unit tests are failing for some unrelated reason:

--- FAIL: TestCloudwatchlogsFilter (0.05s)
    filters_mock_test.go:31: fetch resources [test_resource]
    provider.go:257: [INFO] calculated max goroutines for fetch execution [max_goroutines 65536]
    execution.go:251: [INFO] fetched successfully [count 1]
    --- FAIL: TestCloudwatchlogsFilter/aws_cloudwatchlogs_filters (0.00s)
        --- FAIL: TestCloudwatchlogsFilter/aws_cloudwatchlogs_filters/aws_cloudwatchlogs_filter_metric_transformations (0.00s)
            filters_mock_test.go:31: expected to have at least 1 entry at table aws_cloudwatchlogs_filter_metric_transformations got zero
FAIL
FAIL	github.com/cloudquery/cq-provider-aws/resources/services/cloudwatchlogs	0.072s

@yevgenypats or @bbernays do you happen to know something about this? Otherwise I can investigate

I have never seen this occur before. Maybe it is just the go-faker that randomly set a value to nil (which is a valid value) and in this test we were testing for inserting data into all nested tables?

If we re-run the check does it pass?