Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Resolvers Returning Early #1059

Merged
merged 2 commits into from
Jun 15, 2022
Merged

fix: Resolvers Returning Early #1059

merged 2 commits into from
Jun 15, 2022

Conversation

bbernays
Copy link
Contributor

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@bbernays bbernays requested a review from a team as a code owner June 15, 2022 10:09
@bbernays bbernays requested review from zagronitay and removed request for a team June 15, 2022 10:09
@bbernays bbernays linked an issue Jun 15, 2022 that may be closed by this pull request
Lambda Function Ending Early #1058
Closed
@bbernays bbernays requested a review from roneli June 15, 2022 10:10
@bbernays bbernays changed the title fix: Lambda Function Returning Early fix: Resolvers Returning Early Jun 15, 2022
yevgenypats
yevgenypats suggested changes Jun 15, 2022
View reviewed changes
Copy link
Member

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think we should then add nil checks in subsequent resolvers otherwise it will panic on those?

@bbernays
Copy link
Contributor Author

Looks good but I think we should then add nil checks in subsequent resolvers otherwise it will panic on those?

Why? we are only sending the data to the res channel if there are no errors. These are both examples of where we do a list then a fetch for detail

yevgenypats
yevgenypats approved these changes Jun 15, 2022
View reviewed changes
Copy link
Member

@yevgenypats yevgenypats left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah you are right I thought it was a subresovler, in that case it should work

@bbernays bbernays merged commit 449aefc into cloudquery:main Jun 15, 2022
@bbernays bbernays deleted the fix-lambda branch June 15, 2022 10:23
@cq-bot cq-bot mentioned this pull request Jun 15, 2022
Merged
kodiakhq bot pushed a commit that referenced this pull request Jun 16, 2022
@cq-bot
chore(main): Release v0.12.12 (#1057)
245e4c1 
🤖 I have created a release *beep* *boop*
---


## [0.12.12](v0.12.11...v0.12.12) (2022-06-15)


### Features

* Add VPC Endpoint Services and Configurations ([#1029](#1029)) ([668ea91](668ea91))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.2 ([#1062](#1062)) ([5b2bc76](5b2bc76))
* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.3 ([#1063](#1063)) ([b81b84c](b81b84c))
* Resolvers Returning Early ([#1059](#1059)) ([449aefc](449aefc))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
erezrokah pushed a commit to cloudquery/cloudquery that referenced this pull request Aug 14, 2022
@cq-bot
chore(main): Release v0.12.12 (#1057)
5dec53b 
🤖 I have created a release *beep* *boop*
---


## [0.12.12](cloudquery/cq-provider-aws@v0.12.11...v0.12.12) (2022-06-15)


### Features

* Add VPC Endpoint Services and Configurations ([#1029](cloudquery/cq-provider-aws#1029)) ([668ea91](cloudquery/cq-provider-aws@668ea91))


### Bug Fixes

* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.2 ([#1062](cloudquery/cq-provider-aws#1062)) ([5b2bc76](cloudquery/cq-provider-aws@5b2bc76))
* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.11.3 ([#1063](cloudquery/cq-provider-aws#1063)) ([b81b84c](cloudquery/cq-provider-aws@b81b84c))
* Resolvers Returning Early ([#1059](cloudquery/cq-provider-aws#1059)) ([449aefc](cloudquery/cq-provider-aws@449aefc))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yevgenypats yevgenypats yevgenypats approved these changes

@zagronitay zagronitay Awaiting requested review from zagronitay zagronitay is a code owner automatically assigned from cloudquery/cloudquery-opensource

@roneli roneli Awaiting requested review from roneli

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lambda Function Ending Early
2 participants
@bbernays @yevgenypats