Skip to content
This repository has been archived by the owner on Aug 16, 2022. It is now read-only.

fix: Not Supported region added to error classifier #1006

Merged
merged 2 commits into from
Jun 7, 2022

Conversation

amanenk
Copy link
Contributor

@amanenk amanenk commented Jun 6, 2022

🎉 Thank you for making CloudQuery awesome by submitting a PR 🎉

Summary

Some ec2 resources does not allows some operations and return error like: operation error EC2: DescribeCustomerGateways, https response error StatusCode: 400, RequestID:xxxxxxxxxxxxxxxxxxxxxxxxx, api error UnsupportedOperation: The functionality you requested is not available in this region.
The pr adds this kind of errors to classifier that ignores them.


Use the following steps to ensure your PR is ready to be reviewed

  • Read the contribution guidelines 🧑‍🎓
  • Run go fmt to format your code 🖊
  • Lint your changes via golangci-lint run 🚨 (install golangci-lint here)
  • Update or add tests. Learn more about testing here 🧪
  • Update the docs by running go run ./docs/docs.go and committing the changes 📃
  • If adding a new resource, add relevant Terraform files in a separate PR 📂
  • Ensure the status checks below are successful ✅

@amanenk amanenk marked this pull request as ready for review June 6, 2022 09:12
@amanenk amanenk requested a review from a team as a code owner June 6, 2022 09:12
@amanenk amanenk requested review from bbernays, roneli, shimonp21 and a team and removed request for a team June 6, 2022 09:12
Copy link
Contributor

@roneli roneli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, have one conversation would like to resolve if severity should be warning or ignore. I think the latter.

client/errors.go Show resolved Hide resolved
@amanenk amanenk merged commit be79739 into cloudquery:main Jun 7, 2022
kodiakhq bot pushed a commit that referenced this pull request Jun 8, 2022
🤖 I have created a release *beep* *boop*
---


## [0.12.7](v0.12.6...v0.12.7) (2022-06-07)


### Bug Fixes

* AWS configuration error level owerwrite removed ([#999](#999)) ([32d60e6](32d60e6))
* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.10.10 ([#1014](#1014)) ([2398536](2398536))
* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.10.11 ([#1015](#1015)) ([0c3cf3f](0c3cf3f))
* **deps:** Update module github.com/cloudquery/cq-provider-sdk to v0.10.9 ([#1012](#1012)) ([f566007](f566007))
* Not Supported region added to error classifier ([#1006](#1006)) ([be79739](be79739))
* Update endpoints ([#1017](#1017)) ([729f230](729f230))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants