chore(deps): update terraform cloudposse/rds-cluster/aws to v1.17.0 #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
/terratest |
renovate
bot
force-pushed
the
renovate/cloudposse-rds-cluster-aws-1.x
branch
from
ee2c67e to
6d1a923
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/cloudposse-rds-cluster-aws-1.x
branch
from
6d1a923 to
5f83c81
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/cloudposse-rds-cluster-aws-1.x
branch
from
5f83c81 to
18565ee
Compare
renovate
bot
changed the title
renovate
bot
force-pushed
the
renovate/cloudposse-rds-cluster-aws-1.x
branch
from
18565ee to
a1c644b
Compare
renovate
bot
changed the title
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟠 Require terratestWaiting checks:
|
1 similar comment
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟠 Require terratestWaiting checks:
|
|
Heads up! This pull request looks stale. It will be closed soon, if there are no new commits. ⏳ |
mergify
bot
added
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.3.1->1.17.0Release Notes
cloudposse/terraform-aws-rds-cluster (cloudposse/rds-cluster/aws)
v1.17.0Compare Source
fix: reserved instances, aurora rds specifics @oycyc (#249)
what
RDS Reserved Instances multi AZ mode is never available for Aurora engines, see images on the console - this PR checks to ensure that it is set to false if the engine is Aurora:
why
That configuration isn't really applicable anyways since this statement from the AWS docs https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/USER_WorkingWithReservedDBInstances.html:
references
https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/USER_WorkingWithReservedDBInstances.html
v1.16.0Compare Source
fix: reserved instance multi_az setting @oycyc (#248)
what
Using
local.is_regional_clusterto determine whether or not it is Multi-AZ is not accurate. local.is_regional_cluster only checks if var.cluster_type == "regional", which determines if this is a regional vs global clusterI could have a regional cluster, but it is NOT multi-az. One determining factor is how many instances in the cluster, if ever more than 1 in a single cluster, then it has to be in multiple AZs. https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.MultiAZ.html
why
If I have a regional cluster, this thinks that it's ALWAYS multi-az, which is not true.
references
https://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Concepts.MultiAZ.html
v1.15.1Compare Source
🚀 Enhancements
fix: reserved instances restrictions @oycyc (#244)
what
This conditional check on whether or not to enable reserved instances is too restrictive.
contains(["mysql", "postgresql"], local.reserved_instance_engine)is saying that only allow it if it is MySQL or PostgreSQL.I think
containswas originally meant to be like in the literal sense of "contains". Since in my case, I'm usingaurora-postgresql, and it fails this check, yet it is one of the options for reserved instances.why
endswithmight be better, but it is TOO restrictive, seeing that there's so many options.Additionally, Terraform will fail if user specifies the wrong engine type. There's no need for this check.
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/rds_reserved_instance_offering
🐛 Bug Fixes
fix: reserved instances restrictions @oycyc (#244)
what
This conditional check on whether or not to enable reserved instances is too restrictive.
contains(["mysql", "postgresql"], local.reserved_instance_engine)is saying that only allow it if it is MySQL or PostgreSQL.I think
containswas originally meant to be like in the literal sense of "contains". Since in my case, I'm usingaurora-postgresql, and it fails this check, yet it is one of the options for reserved instances.why
endswithmight be better, but it is TOO restrictive, seeing that there's so many options.Additionally, Terraform will fail if user specifies the wrong engine type. There's no need for this check.
references
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/data-sources/rds_reserved_instance_offering
v1.15.0Compare Source
🚀 Enhancements
reservation_idforaws_rds_reserved_instance) Thank you @oycyc🐛 Bug Fixes
Multiple cleanups @Nuru (#242)
what
why
discussion: why partially revert #236?
PR #236 enhanced the
random_petthat determines part of the name of the DB instances so that the name would change whenever the instances would need to be recreated. Unfortunately, as a side-effect, that causes all instances created with earlier versions of this module to be replaced.Upon further investigation, it was determined that all the "keepers" added by the PR would also force the cluster to be replaced. Unlike replacing an instance, replacing the cluster results in data loss. Also, unless you change the name of the cluster, the module both before and after the PR would fail, because it would try to create a new cluster with the same name before destroying the old cluster.
We prefer this failure mode, requiring the user to explicitly destroy the cluster before creating the new one, because it puts the user on notice about the potential data loss. So given that the changes in the PR did not make something work that did not work before, and it did cause disruption, we reverted the change to the keepers.
v1.14.0Compare Source
fix: reserved instance output @oycyc (#240)
what
Fix the output
How it will look with this:
why
It does not need to be a join with a [*] this will cause error, just referring to it with the resource name will output everything as one object.
references
See the Terraform provider docs https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/rds_reserved_instance#attribute-reference
v1.13.0Compare Source
Output instance endpoints, add attributes to `random_pet` that force a new instance @finchr (#236)
…new instancewhat
why
references
v1.12.0Compare Source
bug/193-enable-http-endpoint @tsaucier0 (#234)
what
why
enable_http_endpointbased on whether the database instance was using serverless architecture. With the introduction of serverless v2 for certain database engines, there is a need to update the logic to accommodate these options.references
Closes #193
v1.11.4Compare Source
🐛 Bug Fixes
fix(reserved instances): use var.instance_type to determine RI offering instead of optional db_instance_class var @kevcube (#235)
the var `db_instance_class` isn't required, so won't always be available. `instance_type` is required.v1.11.3Compare Source
feat: support reserved instances @kevcube (#233)
questions
🤖 Automatic Updates
Update terratest to '>= 0.46.0' @osterman (#215)
what
>= 0.46.0why
References
v1.11.2Compare Source
Dual stack support @ngoyal16 (#231)
what
RDS cluster can be run in two network modes - IPV4 or DUAL.
Underlying module already supports this parameter
why
It can be mandatory to enable it to be able to connect from ipv6 only runtimes
references
Closes #175
🤖 Automatic Updates
Migrate new test account @osterman (#232)
what
.github/settings.yml.github/chatops.ymlfileswhy
.github/settings.ymlfrom org level to getterratestenvironmenttestaccountReferences
Update .github/settings.yml @osterman (#229)
what
.github/settings.yml.github/auto-release.ymlfileswhy
.github/settings.ymlfrom org levelreferences
Update .github/settings.yml @osterman (#228)
what
.github/settings.yml.github/auto-release.ymlfileswhy
.github/settings.ymlfrom org levelreferences
v1.11.1Compare Source
🚀 Enhancements
fix: Too long identifier name error @MaxymVlasov (#226)
what
Fix too long identifier name without cluster recreation:
set
id_length_limit = 40forwill cause such recreation if final
module.this.idwill be between 40-60 characterswhy
https://github.com/cloudposse/terraform-aws-rds-cluster/releases/tag/1.10.0 introduced
random_pet, which adds 2 extra words on the top ofmodule.this.id, and that exceed limit of 63 allowed characters for RDS namesThis PR limit final identifier to 62-63 chars (depends on count of replica)
references
Fixing https://github.com/cloudposse/terraform-aws-rds-cluster/pull/213
🐛 Bug Fixes
fix: Too long identifier name error @MaxymVlasov (#226)
what
Fix too long identifier name without cluster recreation:
set
id_length_limit = 40forwill cause such recreation if final
module.this.idwill be between 40-60 characterswhy
https://github.com/cloudposse/terraform-aws-rds-cluster/releases/tag/1.10.0 introduced
random_pet, which adds 2 extra words on the top ofmodule.this.id, and that exceed limit of 63 allowed characters for RDS namesThis PR limit final identifier to 62-63 chars (depends on count of replica)
references
Fixing https://github.com/cloudposse/terraform-aws-rds-cluster/pull/213
v1.11.0Compare Source
feat: manage master credentials in secrets manager @pazaan (#221)
what
Allow to manage master credentials in Secrets Manager
why
Managed secrets are more secure and easy to use.
references
v1.10.2Compare Source
🚀 Enhancements
fix: pass var.db_port to RDS cluster instances @emmanuelchibuogwu (#222)
what
Currently, the
var.db_portvariable is not passed to bothaws_rds_clusterresources.why
var.db_portis passed to the security group but not the cluster instances, this results to the following cases:var.db_portto a value other than the default makes the cluster inaccessible .references
🐛 Bug Fixes
fix: pass var.db_port to RDS cluster instances @emmanuelchibuogwu (#222)
what
Currently, the
var.db_portvariable is not passed to bothaws_rds_clusterresources.why
var.db_portis passed to the security group but not the cluster instances, this results to the following cases:var.db_portto a value other than the default makes the cluster inaccessible .references
v1.10.1Compare Source
🚀 Enhancements
Fix conflicting `restore_to_point_in_time` attributes @ericluria (#217)
what
use_latest_restorable_timeandrestore_to_timewhile preserving existing default values for backwards compatibilitywhy
references
🐛 Bug Fixes
Fix conflicting `restore_to_point_in_time` attributes @ericluria (#217)
what
use_latest_restorable_timeandrestore_to_timewhile preserving existing default values for backwards compatibilitywhy
references
v1.10.0Compare Source
reopen #192 @finchr (#213)
what
I implemented create_before_destroy on the aws_rds_cluster_instance default instances.
Originally in #192 but that was closed for reasons we won't go into here.
why
Making a change to any parameter that triggers a replace on a aws_rds_cluster_instance results in all instances being destroyed before attempting to create a new instance which causes an outage. This a faster (and safer) altenative to https://github.com/cloudposse/terraform-aws-rds-cluster/pull/191
references
This closes https://github.com/cloudposse/terraform-aws-rds-cluster/issues/190 and is an alternative to https://github.com/cloudposse/terraform-aws-rds-cluster/pull/191
v1.9.1Compare Source
Support restoring to a specific time @ericluria (#216)
what
restore_to_timeas an attribute of therestore_to_point_in_timeparameter, allowing to restore to a specific datetime rather than the latest restorable time.why
aws_rds_clusterresource.references
questions
I noticed while making this PR thatsource_cluster_identifierdefaults to"120m", which looks like an inadvertent copy-and-paste from another parameter. In theaws_rds_clusterresource, this parameter is required, so it doesn't make sense to have a default anyway. Would you recommend leaving this parameter as-is, or should we fix it?edit: fixed as part of this PR
🤖 Automatic Updates
Update release workflow to allow pull-requests: write @osterman (#214)
what
.github/workflows/release.yaml) to have permission to comment on PRwhy
Update GitHub Workflows to use shared workflows from '.github' repo @osterman (#212)
what
.github/workflows) to use shared workflows from.githubrepowhy
Update GitHub Workflows to Fix ReviewDog TFLint Action @osterman (#211)
what
.github/workflows) to addissue: writepermission needed by ReviewDogtflintactionwhy
Update GitHub workflows @osterman (#210)
what
.github/workflows/settings.yaml)why
Use GitHub Action Workflows from `cloudposse/.github` Repo @osterman (#207)
what
why
cldouposse/.githubrepositoryv1.9.0Compare Source
add option for enabling global write forwarding @tdockseydt (#186)
what
Add option for enabling global write forwarding for aws rds cluster.
why
🤖 Automatic Updates
Bump google.golang.org/grpc from 1.51.0 to 1.56.3 in /test/src @dependabot (#204)
Bumps google.golang.org/grpc from 1.51.0 to 1.56.3.
Release notes
Sourced from google.golang.org/grpc's releases.
... (truncated)
Commits
1055b48Update version.go to 1.56.3 (#6713)5efd7bdserver: prohibit more than MaxConcurrentStreams handlers from running at once...bd1f038Upgrade version.go to 1.56.3-dev (#6434)faab873Update version.go to v1.56.2 (#6432)6b0b291status: fix panic when servers return a wrapped error with status OK (#6374) ...ed56401[PSM interop] Don't fail target if sub-target already failed (#6390) (#6405)cd6a794Update version.go to v1.56.2-dev (#6387)5b67e5eUpdate version.go to v1.56.1 (#6386)d0f5150client: handle empty address lists correctly in addrConn.updateAddrs (#6354) ...997c1eaChange version to 1.56.1-dev (#6345)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.
Add GitHub Settings @osterman (#200)
what
.github/settings.yaml)why
Add GitHub Settings @osterman (#198)
what
.github/settings.yamlwhy
Update README.md and docs @cloudpossebot (#195)
what
This is an auto-generated PR that updates the README.md and docs
why
To have most recent changes of README.md and doc from origin templates
Update Scaffolding @osterman (#196)
what
make readmeto rebuildREADME.mdfromREADME.yamlwhy
.githubrepoUpdate Terraform cloudposse/dynamic-subnets/aws to v2.4.2 @renovate (#194)
This PR contains the following updates:
2.4.1->2.4.2Release Notes
cloudposse/terraform-aws-dynamic-subnets (cloudposse/dynamic-subnets/aws)
v2.4.2Compare Source
🚀 Enhancements
chore(deps): update terraform cloudposse/utils/aws to v1.4.0 (main) @​renovate (#​191)
This PR contains the following updates:
1.3.0->1.4.0Release Notes
cloudposse/terraform-aws-utils (cloudposse/utils/aws)
v1.4.0Compare Source
Add il-central-1 region @​&#​8203;jasonmk (#&#​8203;31)
what
Add new Tel Aviv (il-central-1) region
why
Provide full coverage
references
Sync github @​&#​8203;max-lobur (#&#​8203;27)
Rebuild github dir from the template
🤖 Automatic Updates
chore(deps): update terraform cloudposse/utils/aws to v1.4.0 (main) @​renovate (#​191)
This PR contains the following updates:
1.3.0->1.4.0Release Notes
cloudposse/terraform-aws-utils (cloudposse/utils/aws)
v1.4.0Compare Source
Add il-central-1 region @​&#​8203;jasonmk (#&#​8203;31)
what
Add new Tel Aviv (il-central-1) region
why
Provide full coverage
references
Sync github @​&#​8203;max-lobur (#&#​8203;27)
Rebuild github dir from the template
Update README.md and docs @​cloudpossebot (#​189)
what
This is an auto-generated PR that updates the README.md and docs
why
To have most recent changes of README.md and doc from origin templates
v1.8.0Compare Source
implement simple rolling update using depends_on @finchr (#191)
what
Implement a simple rolling update for the aws_rds_cluster_instance default instances.
why
To implement a zero downtime deploy for simple changes.
references
closes #190
v1.7.1Compare Source
Allow to configure storage type for global databases @bentmann (#189)
what
Use existing
storage_typevariable for global DBs, too. Currently, it is only set for regional clusters.why
Aurora clusters offer two different storage types, standard and I/O-Optimized. Which one is employed for clusters in a global DB should be configurable to be able to realize cost savings that I/O-Optimized offers for certain workloads.
references
🤖 Automatic Updates
Update README.md and docs @cloudpossebot (#187)
what
This is an auto-generated PR that updates the README.md and docs
why
To have most recent changes of README.md and doc from origin templates
v1.7.0Compare Source
Add serverlessv2 config to aws_rds_cluster.secondary @asmithdt (#181)
what
Add missing config to
aws_rds_cluster.secondarywhy
Tested on my cluster and confirmed to work when a serverless configuration is provided.
v1.6.0Compare Source
Add `parameter_group_name_prefix_enabled` variable. Update examples and tests @aknysh (#179)
what
parameter_group_name_prefix_enabledvariable (defaults totrueto maintain the current functionality)nameandname_prefixattributes inaws_rds_cluster_parameter_groupandaws_db_parameter_groupresourceswhy
nameattribute (which was the only option in the old versions of the module) instead ofname_prefixattributereferences
Support AWS Provider V5 @max-lobur (#170)
what
Support AWS Provider V5
Linter fixes
why
Maintenance
references
https://github.com/hashicorp/terraform-provider-aws/releases/tag/v5.0.0
Sync github @max-lobur (#167)
Rebuild github dir from the template
v1.5.0Compare Source
v1.4.0Compare Source
Support for Activity Stream added @ngoyal16 (#159)
what
Added by @nuru:
why
v1.3.2Compare Source
🚀 Enhancements
Fix: InvalidParameterValue: CreateDBInstance error when creating non-aurora multi a-z rds cluster and aws provider update @matharoo (#149)
what
aws_rds_cluster_instanceresource when engine type isNOTaurora,aurora-mysql,aurora-postgresqlrebootingstate. I have a PR merged with terraform-aws-provider that fixes it and will be included in the next release4.23.0.why
rebootingstate when creating multi a-z cluster.references
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.