Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] - Support ConversionWebhooks generated with Kubebuilder #883

Open
3 tasks
IvoGoman opened this issue Feb 5, 2025 · 0 comments
Open
3 tasks

[FEAT] - Support ConversionWebhooks generated with Kubebuilder #883

IvoGoman opened this issue Feb 5, 2025 · 0 comments
Labels

Comments

@IvoGoman
Copy link
Contributor

IvoGoman commented Feb 5, 2025

Priority

None

User Story

As a Greenhouse developer, I would like to generate ConversionWebhooks using the Bubebuilder CLI, so that I can easily add migrations between API Versions.

Description

The current project setup does not allow for generating working ConversionWebhooks due to

  1. kube-webhook-certgen does not work with CRDs. The .spec.conversion.webhookClientConfig can not be injected.
  2. generation of ConversionWebhooks with Kubebuilder CLI does not work with the Project structure changed from default scaffolding

Decision: conversion should be tested with e2e tests. Existing unit tests should only test the most current API versions

Acceptance Criteria

  • cert-manager is used in HelmChart to inject certificates for webhookClientConfig in CRDs and Webhooks
  • cert-manager is used in e2e tests to inject certificates for webhookClientConfig in CRDs and Webhooks
  • greenhouse project is updated to kubebuilder/v4 project structure

Reference Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Sprint Backlog
Development

No branches or pull requests

1 participant