From 9f4080ec88a8929e74462383c0752ebe9b4e5da6 Mon Sep 17 00:00:00 2001 From: Sakala Venkata Krishna Rohit Date: Thu, 9 Jul 2020 07:54:24 +0200 Subject: [PATCH] Make update checking stricter in qsecret controller --- .../controllers/quarkssecret/quarkssecret_controller.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkg/kube/controllers/quarkssecret/quarkssecret_controller.go b/pkg/kube/controllers/quarkssecret/quarkssecret_controller.go index 7f4c5a5f..605393ed 100644 --- a/pkg/kube/controllers/quarkssecret/quarkssecret_controller.go +++ b/pkg/kube/controllers/quarkssecret/quarkssecret_controller.go @@ -3,6 +3,7 @@ package quarkssecret import ( "context" "fmt" + "reflect" "github.com/pkg/errors" corev1 "k8s.io/api/core/v1" @@ -63,6 +64,11 @@ func AddQuarksSecret(ctx context.Context, config *config.Config, mgr manager.Man n := e.ObjectNew.(*qsv1a1.QuarksSecret) o := e.ObjectOld.(*qsv1a1.QuarksSecret) + if reflect.DeepEqual(n.Spec, o.Spec) && reflect.DeepEqual(n.Labels, o.Labels) && + reflect.DeepEqual(n.Annotations, o.Annotations) && reflect.DeepEqual(n.Status, o.Status) { + return false + } + // When should we reconcile? // | old | new | reconcile? | // | ----- | ----- | ---------- |