Skip to content
This repository has been archived by the owner on Feb 7, 2023. It is now read-only.

Fix request.cf types #296

Closed
caass opened this issue Oct 17, 2022 · 0 comments · Fixed by #301
Closed

Fix request.cf types #296

caass opened this issue Oct 17, 2022 · 0 comments · Fixed by #301
Assignees
@caass
Labels
enhancement New feature or request

Comments

@caass
Copy link
Contributor

caass commented Oct 17, 2022 •
edited
Loading

Currently, the types defined on the cf property on incoming requests are kind of ad-hoc. We should investigate what properties get added by cloudflare, and make the type better -- meaning properties are documented indicating what they are, and whether they're available on all plans, etc.
@caass caass added the enhancement New feature or request label Oct 17, 2022
@caass caass self-assigned this Oct 17, 2022
@caass caass moved this to Untriaged in workers-sdk Oct 17, 2022
@caass caass changed the title Auto-generate request.cf types Fix request.cf types Oct 18, 2022
@caass caass moved this from Untriaged to In Progress in workers-sdk Oct 18, 2022
@caass caass mentioned this issue Oct 19, 2022
Merged
Repository owner moved this from In Progress to Done in workers-sdk Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@caass caass

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

begin implementing real real good types for request.cf cloudflare/workers-types
1 participant
@caass