Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

datasource format fix #76

Merged
merged 1 commit into from
Aug 8, 2018
Merged

datasource format fix #76

merged 1 commit into from
Aug 8, 2018

Conversation

XooR
Copy link

@XooR XooR commented Jul 25, 2018

This is format which is used in newer version of Grafana.
We should have apiVersion if it's not there I had problems with jsonData not being read by Grafana.
Also delete_datasources should be deleteDatasources.

@paulfantom
Copy link
Member

Looks like there are some problems with this. Have you tried to test it locally (https://github.com/cloudalchemy/ansible-grafana#local-testing)?

@paulfantom paulfantom mentioned this pull request Jul 26, 2018
Closed
@aaronk6 aaronk6 mentioned this pull request Aug 5, 2018
Closed
@XooR
Copy link
Author

XooR commented Aug 6, 2018

I have tried to run test locally and they fail. I just need to figure out why, for CentOS7 and Fedora.

I will check it during this week so you can merge.

@paulfantom
Copy link
Member

Tested locally, it works. Must be some strange test flake.

@paulfantom paulfantom merged commit 8b8ead4 into cloudalchemy:master Aug 8, 2018
This was referenced Aug 8, 2018
Closed
Closed
@lock
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XooR @paulfantom