This repository has been archived by the owner on May 31, 2023. It is now read-only.
extending regex to match multiple subsequent words in datasource placeholder #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odyssey4me
reviewed
Apr 26, 2018
tasks/dashboards.yml
Outdated
| # 4. A one-or-more case-sensitive match for the part that follows the | ||
| # underscore, with no characters allowed except alphabetical. | ||
| # 3. A case-sensitive literal match for DS . | ||
| # 4. One or more case-sensitive matches for groups of alphabetical characters |
There was a problem hiding this comment.
Remove the trailing whitespace here.
odyssey4me
suggested changes
Apr 26, 2018
odyssey4me
reviewed
Apr 26, 2018
placeholder which is slightly more complex than what the regex
currently supports. As such we are extending the regex to
allow more than just one word following the "DS_" prefix.
We do this by following the following rules:
- Literal boundaries for " on either side of the match.
- Non-capturing optional group matches for the ${} bits which may, or
may not, be there..
- A case-sensitive literal match for DS .
- One or more case-sensitive matches for groups of alphabetical characters
where each group is preceded by an underscore.
aman0019
force-pushed
the
extend-dashboard-regex-patterns
branch
from
5fd90d7 to
23f78f5
Compare
odyssey4me
approved these changes
Apr 27, 2018
|
thanks :) |
odyssey4me
pushed a commit
to odyssey4me/ansible-grafana
that referenced
this pull request
May 22, 2018
In order to match datasources like "DS_DML-PROM0" which include dashes and numbers, we open the match to include them. We also remove the capture groups implemented in [1] as they're not required and their inclusion makes things more difficult to understand. Instead, we provide the same function by simply also allowing underscores in the match. [1] cloudalchemy#53
odyssey4me
pushed a commit
to odyssey4me/ansible-grafana
that referenced
this pull request
May 22, 2018
In order to match datasources like "DS_DML-PROM0" which include dashes and numbers, we open the match to include them. We also remove the capture groups implemented in [1] as they're not required and their inclusion makes things more difficult to understand. Instead, we provide the same function by simply also allowing underscores in the match. [1] cloudalchemy#53 Fixes cloudalchemy#59
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered that some grafana dashboards use a datasource
placeholder which is slightly more complex than what the regex
currently supports. As such we are extending the regex to
allow more than just one word following the "DS_" prefix.
We do this by following the following rules:
may not, be there..
where each group is preceded by an underscore.