This repository has been archived by the owner on May 31, 2023. It is now read-only.
datasources: Allow additional datasources to be created later #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the role only allows the datasources to be configured on the first implementation. From then on if there are any data sources configured, the task to upload any new configuration is ignored. This patch implements a validation for each datasource item to check whether it's already configured using the name as the key. If the item is not configured, it will configure it.
paulfantom
approved these changes
Mar 23, 2018
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the role only allows the datasources to be configured
on the first implementation. From then on if there are any data
sources configured, the task to upload any new configuration is
ignored.
This patch implements a validation for each datasource item to
check whether it's already configured using the name as the key.
If the item is not configured, it will configure it.