Add Ubuntu Bionic support/testing #39
Conversation
|
Odd, the image referenced is public so it should work. I'm entirely new at using docker though, so any pointers which might help are welcome. :) This relates to paulfantom/dockerfiles#1 |
molecule.yml
Outdated
| @@ -17,6 +17,12 @@ docker: | |||
| privileged: true | |||
| volume_mounts: | |||
| - /sys/fs/cgroup:/sys/fs/cgroup:ro | |||
| - name: bionic | |||
| image: odyssey4me/ubuntu-molecule | |||
There was a problem hiding this comment.
I'll adjust this once paulfantom/dockerfiles#1 merges and the image is published.
There was a problem hiding this comment.
PR is merged and images are public 🎉
There was a problem hiding this comment.
Awesome, thanks!
|
This is great! Just change image name and I'll merge it. |
README.md
Outdated
| @@ -68,7 +68,7 @@ We provide demo site for full monitoring solution based on prometheus and grafan | |||
| The preferred way of locally testing the role is to use Docker and [molecule](https://github.com/metacloud/molecule) (v1.25). You will have to install Docker on your system. See Get started for a Docker package suitable to for your system. | |||
| All packages you need to can be specified in one line: | |||
| ```sh | |||
| pip install ansible ansible-lint>=3.4.15 molecule==1.25.0 docker testinfra>=1.7.0 | |||
| pip install ansible 'ansible-lint>=3.4.15' 'molecule==1.25.0' docker git-semver 'testinfra>=1.7.0,<=1.10.1' | |||
There was a problem hiding this comment.
One thing, git-semver isn't needed for local testing, please remove it from this line.
|
And about issue with travis not downloading your docker image: |
|
Thanks for the tip about the images script - I missed that! |
To ensure the instructions are accurate (based on .travis.yml) and also to ensure that the shell interpreter does not interpret the requirements boundaries for each pip requirement as something else, the install line is updated.
In order to support and to validate support for Ubuntu 18.04 (Bionic), we add the appropriate molecule configuration to test it, along with the only change necessary for the tests to pass. A trailing whitespace is also removed from .travis/images.sh as it's unnecessary.
|
Thanks! |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
In order to support and to validate support for
Ubuntu 18.04 (Bionic), we add the appropriate
molecule configuration to test it, along with
the only change necessary for the tests to pass.