Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Add tag grafana_run to give flexibility #151

Merged

Conversation

bryanspears
Copy link
Contributor

The intention was to give myself a --skip-tags target to prevent grafana-server from starting at all.

Reasoning: We use replacement variables in the configuration for different environments (i.e. dev, prod, etc.) and attempting to start grafana with those replacements blows up, as would be expected.

I'm relatively new to Ansible. Open to suggestions.

@bryanspears bryanspears changed the title Add tag grafana_started to add some flexibility Add tag grafana_started to give flexibility Apr 16, 2019
@paulfantom
Copy link
Member

paulfantom commented Apr 16, 2019

Could you please change tag name from grafana_started to grafana_run to be consistent with other repositories in @cloudalchemy organisation?

Also remember that skipping this tag doesn't mean grafana won't start as this role is installing it from official packages. Which means that debian installations will start grafana server by default and RHEL ones won't. Running service task creates consistent behavior across all distros.

@bryanspears
Copy link
Contributor Author

Correct. This is intended to allow the playbook to complete with "bad" configuration.

@paulfantom paulfantom changed the title Add tag grafana_started to give flexibility Add tag grafana_run to give flexibility Apr 16, 2019
@paulfantom paulfantom merged commit fbc3b55 into cloudalchemy:master Apr 16, 2019
cosandr pushed a commit to cosandr/ansible-grafana that referenced this pull request Aug 12, 2020
* Add grafana_started tag to allow skipping grafana start

* Try to prevent restart handler

* Change tag to grafana_run
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants