This repository has been archived by the owner on May 31, 2023. It is now read-only.
Only set alerting if variable is false #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current configuration template doesn't allow for disabling the alerting. It is enabled by default. This small patch makes sure we can disable the alerting.
|
For reference: http://docs.grafana.org/installation/configuration/#alerting |
paulfantom
suggested changes
Nov 20, 2018
templates/grafana.ini.j2
Outdated
| @@ -96,9 +96,9 @@ enabled = true | |||
| path = {{ grafana_data_dir }}/dashboards | |||
|
|
|||
| # Alerting | |||
| {% if grafana_alerting %} | |||
| {% if grafana_alerting == false %} | |||
There was a problem hiding this comment.
It should be written as if not grafana_alerting
paulfantom
approved these changes
Nov 20, 2018
dimavin
pushed a commit
to intento/ansible-grafana
that referenced
this pull request
Jan 16, 2019
* Only set alerting if variable is false The current configuration template doesn't allow for disabling the alerting. It is enabled by default. This small patch makes sure we can disable the alerting. * implement use of 'if not' conditional
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current configuration template doesn't allow for disabling the alerting. It is enabled by default. This small patch makes sure we can disable the alerting.