Skip to content
This repository has been archived by the owner on May 31, 2023. It is now read-only.

Dashboard datasource regex does not match for some dashboards #59

Closed
0xFelix opened this issue May 22, 2018 · 1 comment
Closed

Dashboard datasource regex does not match for some dashboards #59

0xFelix opened this issue May 22, 2018 · 1 comment
Assignees

Comments

@0xFelix
Copy link

0xFelix commented May 22, 2018

Some dashboards use a datasource placeholder like DS_DML-PROM0 but the placeholder regex currently does not match on it.

regexp: '"(?:\${)?DS(_([A-Z])+)+(?:})?"'

The regex should be changed to: "(?:\${)?DS_[0-9A-Z-]+(?:})?" so the placeholder matches.

odyssey4me pushed a commit to odyssey4me/ansible-grafana that referenced this issue May 22, 2018
In order to match datasources like "DS_DML-PROM0" which include dashes
and numbers, we open the match to include them. We also remove the
capture groups implemented in [1] as they're not required and their
inclusion makes things more difficult to understand. Instead, we provide
the same function by simply also allowing underscores in the match.

[1] cloudalchemy#53

Fixes cloudalchemy#59
@lock
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019
cosandr pushed a commit to cosandr/ansible-grafana that referenced this issue Aug 12, 2020
In order to match datasources like "DS_DML-PROM0" which include dashes
and numbers, we open the match to include them. We also remove the
capture groups implemented in [1] as they're not required and their
inclusion makes things more difficult to understand. Instead, we provide
the same function by simply also allowing underscores in the match.

[1] cloudalchemy#53

Fixes cloudalchemy#59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants