Bug in tags.py filter_resources methods

[kevinl-grab]

Describe the bug

The code iterates over a list, altering the list in-place, and also maintaining an index. The index gets out of sync every time an item is popped from the list.

#7740 shows the code in question, and a proposed fix (I'm chasing the status of submitting to CNCF projects internally, but if I can't, take this PR as an indication of where and what the bug is and there's any number of other ways it could be resolved).

What did you expect to happen?

Suggest not operating in-place on the resources list, and I expect the returned list to be accurate.

Cloud Provider

Amazon Web Services (AWS)

Cloud Custodian version and dependency information

No response

Policy

No response

Relevant log/traceback output

No response

Extra information or context

No response

[MadhuMPandurangi]

Hi @kevinl-grab, I'm interested in contributing to this issue. Can u please assign this to me