Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically Add Dependencies to clib.json when clib install is called. #291

Closed
phoenixpinpoint opened this issue Jul 28, 2023 · 2 comments · Fixed by #299
Closed

Automatically Add Dependencies to clib.json when clib install is called. #291

phoenixpinpoint opened this issue Jul 28, 2023 · 2 comments · Fixed by #299

Comments

@phoenixpinpoint
Copy link

One of the things I have noticed is dependencies are not added to clib.json when clib install is called. This would make this easier to use than it already is.

@exbotanical
Copy link
Contributor

I looked at the clib code because I wanted to implement this and found that the feature is already there. Run install with the -S or --save flag.

Seems this behavior was inspired by npm, which as of v5 saves deps to package.json by default (ref). Nowadays npm supports --no-save (or -no- prepended to pretty much any flag) to negate the behavior.

This makes more sense to me as a default behavior. If the maintainers are good with it, I'll make the change.

@jwerle
Copy link
Member

jwerle commented Oct 28, 2023

I looked at the clib code because I wanted to implement this and found that the feature is already there. Run install with the -S or --save flag.

Seems this behavior was inspired by npm, which as of v5 saves deps to package.json by default (ref). Nowadays npm supports --no-save (or -no- prepended to pretty much any flag) to negate the behavior.

This makes more sense to me as a default behavior. If the maintainers are good with it, I'll make the change.

yeah we'd happily review a PR for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants