Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DocumentLists support behind a flag #314

Open
CKEditor5 opened this issue Apr 7, 2022 · 4 comments
Open

Add DocumentLists support behind a flag #314

CKEditor5 opened this issue Apr 7, 2022 · 4 comments
Labels
feature An idea for a new functionality or a missing option squad:features

Comments

@CKEditor5
Copy link

So, Document lists (ckeditor/ckeditor5#2973) are now available as an experimental feature.

It'd be cool if we could test this feature in GH Writer.

It's perhaps too early to turn it on by default so this could be hidden behind some flag.

Potential problems:

  • Markdown support for the DocLists output. It's much more complex and there's a risk of often running into Markdown's inability to reflect the HTML outputted by DocLists.
  • Stability of DocLists for now.
@mateuszzagorski mateuszzagorski added squad:features feature An idea for a new functionality or a missing option labels Jul 4, 2022
@mlewand
Copy link
Contributor

mlewand commented Sep 5, 2022

@mateuszzagorski let's give it a try if it can be easily integrated. Let's work on this up to 2 mds. If it doesn't come easily we'll drop it for time being.

@mateuszzagorski
Copy link
Contributor

As stated in the docs  - the DocumentList can not be loaded together with the 'List" plugin - so as of this moment we would have to turn the ToDoList plugin off, as they cannot work together in the current state.

Branch where you can test the DocumentList working can be found here: ghw/314-document-list-integration.

Short video showing how it looks like when used with the GitHub Writer:

Nagranie.z.ekranu.2022-09-6.o.11.49.44.mov

@mlewand
Copy link
Contributor

mlewand commented Sep 7, 2022

Unfortunately despite the fact that conversion (to md) works fine, we need to drop this improvement for now because todo list is also essential feature of GH writer.

For now it seems that integrating todolists with document lists is a bigger task and we don't have the means to do it .

@Reinmar
Copy link
Member

Reinmar commented Sep 7, 2022

That's why I proposed:

It's perhaps too early to turn it on by default so this could be hidden behind some flag.

It can be implemented in a really simple way – by reading that flag from a local storage.

And since the goal here is to enable DocLists for the core CKE5 team, that's completely enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature An idea for a new functionality or a missing option squad:features
Projects
None yet
Development

No branches or pull requests

4 participants