Skip to content
This repository has been archived by the owner on Jul 23, 2024. It is now read-only.

Strikethrough #3

Closed
Comandeer opened this issue Dec 3, 2015 · 6 comments
Closed

Strikethrough #3

Comandeer opened this issue Dec 3, 2015 · 6 comments
Labels
Milestone

Comments

@Comandeer
Copy link
Member

That feature is probably also neccessary, as it's the easiest way to mark something as not longer appropiate or had been deleted.

Therefore we should consider two elements for that:

  • s element - the most generic element used to mark something not longer relevant
  • del element - the element used to mark the removal of some parts of content (it probably suits better to some kind of "Suggestions" feature, but should be also considered here).

CKE4 is using s or strike elements for it as a part of basicstyles plugin.

@fredck
Copy link
Contributor

fredck commented Dec 3, 2015

In my personal opinion, s is the one and only way to go.

@Comandeer
Copy link
Member Author

s is more generic, so it can be "abused" to use cases where del is more appropiate (as document edits are also the parts of content that are not longer relevant), so I also think that it's better choice here. del is too "formal" for generic feature (datetimes, sources of edit…) - it's intended to be uses in documents such as HTML5 spec.

@Comandeer
Copy link
Member Author

Some stats. I've checked 22 editors to see how they implement some basic features.

"Strike" is absent in 9 editors, the rest implements it as follows:

  • 4 of them use s
  • 4 of them use strike
  • 2 of them use span[style]
  • 2 of them use del
  • 1 uses own syntax, based on XML (text:span)

@Comandeer Comandeer added this to the Features milestone Dec 22, 2015
@Comandeer Comandeer changed the title Strike Strikethrough Dec 30, 2015
@Comandeer
Copy link
Member Author

Actually the name of that feature is "strikethrough", not "strike". I've changed it.

@Comandeer
Copy link
Member Author

I created the first version of draft for that feature: http://ckeditor.github.io/editor-recommendations/features/strikethrough.html
Feel free to comment or even prepare some PR to improve it!

@Comandeer
Copy link
Member Author

Ok, it seems like a stable feature. I propose moving it from draft to the recommendation status. I'll wait 3 days for objections and then do what should be done ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants