-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix incorrect upcast scan table heuristics responsible for creating heading rows. #17640
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix is working as expected, didn't found any side effects 👍
Great news that this one has been fixed, nice work! Any rough idea on when it might get released? |
Mid-Jan or early February. |
Excellent, thanks! |
@Proudloaf While we'll release it in the stable next year, there is a way to check it on our nightly builds. Keep in mind, that it's unstable and should not be used on production. |
Fair enough, we're planning on updating to 44.1.0 very soon anyway, so once we have that stable we'll give it a go on your nightly. Thanks |
Suggested merge commit message (convention)
Fix (table): Prevent table corruption when setting editor data with
th
cells followingcolspan
rows. Closes #17556, #17404Additional information
Our table upcasting does not recognize colspans correctly during calculation of the header rows. This PR ensures that rows that follow the rows with colspans are not longer used as table headings.
Check this HTML
Before
After