Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unify TypeScript declaration files #17597

Merged
merged 5 commits into from
Dec 16, 2024
Merged

Conversation

filipsobol
Copy link
Member

Suggested merge commit message (convention)

Fix: Unify TypeScript declaration files. Fixes #17575 and #17533.

@filipsobol filipsobol requested a review from pomek December 6, 2024 09:59
Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@charlttsie
Copy link
Contributor

We've completed the QA tests with @MarBourb in setups using different installation methods and it looks good to us 👍

@filipsobol
Copy link
Member Author

I've tested the internal release against both linked issues and the fix seems to work fine.

@filipsobol filipsobol merged commit 417c261 into master Dec 16, 2024
10 checks passed
@filipsobol filipsobol deleted the unify-declaration-files branch December 16, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot combine imports from ckeditor5 with deep imports
3 participants