Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The LinkImage plugin should be on for all editor builds because of inline images #9482

Closed
oleq opened this issue Apr 15, 2021 · 5 comments
Closed
Labels
package:image package:link resolution:expired This issue was closed due to lack of feedback. squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".

Comments

@oleq
Copy link
Member

oleq commented Apr 15, 2021

Because linking inline images is now possible (see #8871), it would make no sense if integrations that have inline images enabled (this will be default in all builds) would not allow creating this kind of content:

<p><a href="...">foo<img />bar</a></p>

but

<p><a href="...">foo</a><img /><a href="...">bar</a></p>

instead only because the imageInline in the model does not support the linkHref attribute. That would make no sense at all.

OTOH, ATM LinkImage is an optional plugin and enabling it in all builds would be a huge breaking change because that would suddenly make block images linkable, which in turn may be unexpected (in a negative sense) for some integrations.

Going even further, these integrations may want linking inline images possible (because they are inline, this is very natural) but they may not want linked block images.

I guess, just like the Image plugin, we'll need to split LinkImage into LinkImage (as a glue) and LinkBlockImage and LinkInlineImage to at least make it configurable and then we can figure out which of these should be enabled in builds.

@oleq oleq added package:image squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos". package:link labels Apr 15, 2021
@Reinmar Reinmar added this to the nice-to-have milestone Aug 3, 2021
@Reinmar
Copy link
Member

Reinmar commented Aug 18, 2021

Waiting for feedback from @wwalc on this. It's not a frequently added plugin to any of the builds according to the stats. OTOH, that's actually surprising to me. I thought it's included in all builds and never thought about this.

@Reinmar
Copy link
Member

Reinmar commented Aug 18, 2021

One interesting note: When there's no LinkImage enabled, you can apply the link to a block image... because it gets applied to the caption (only). So this is quite confusing because the link balloon can be opened in this case but only for block images.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may still be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added resolution:expired This issue was closed due to lack of feedback. and removed status:stale labels Jan 15, 2024
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:image package:link resolution:expired This issue was closed due to lack of feedback. squad:core Issue to be handled by the Core team. type:task This issue reports a chore (non-production change) and other types of "todos".
Projects
None yet
Development

No branches or pull requests

4 participants