Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List view with a class name is always split into multiple lists #8734

Open
mlewand opened this issue Dec 30, 2020 · 0 comments
Open

List view with a class name is always split into multiple lists #8734

mlewand opened this issue Dec 30, 2020 · 0 comments
Assignees
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:list squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.

Comments

@mlewand
Copy link
Contributor

mlewand commented Dec 30, 2020

📝 Provide detailed reproduction steps (if any)

I was adding support for ol[class] attribute, so I added a listItem[listClass] attribute (similarly as we keep listType)

 in the model.

However, when downcasting each list item gets placed in a separate list, while all should be placed in a single list wrapper. Note the numbering being restart:

Interestingly if I change view attribute name from class to something else, e.g. data-class it works as expected and no multiple lists are created.

I created a demo:

✔️ Expected result

List should not be split.

❌ Actual result

List is being split.


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@mlewand mlewand added type:bug This issue reports a buggy (incorrect) behavior. package:list support:1 An issue reported by a commercially licensed client. support:2 An issue reported by a commercially licensed client. and removed support:1 An issue reported by a commercially licensed client. labels Dec 30, 2020
@Reinmar Reinmar modified the milestones: backlog, nice-to-have Jan 4, 2021
@Reinmar Reinmar added the squad:core Issue to be handled by the Core team. label Jan 4, 2021
@Reinmar Reinmar added squad:compat and removed squad:core Issue to be handled by the Core team. labels Jan 18, 2021
@Reinmar Reinmar added domain:v4-compatibilty domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. and removed domain:v4-compatibilty labels Mar 9, 2021
@jacekbogdanski jacekbogdanski modified the milestones: nice-to-have, iteration 45 Jul 22, 2021
@Mgsy Mgsy modified the milestones: iteration 45, nice-to-have Aug 2, 2021
@Reinmar Reinmar added squad:core Issue to be handled by the Core team. and removed squad:compat labels Sep 27, 2021
@pomek pomek removed this from the nice-to-have milestone Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain:v4-compatibility This issue reports a CKEditor 4 feature/option that's missing in CKEditor 5. package:list squad:core Issue to be handled by the Core team. support:2 An issue reported by a commercially licensed client. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

5 participants