Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link plugin with internal links #7618

Closed
marcellofuschi opened this issue Jul 13, 2020 · 3 comments
Closed

Link plugin with internal links #7618

marcellofuschi opened this issue Jul 13, 2020 · 3 comments
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.

Comments

@marcellofuschi
Copy link
Contributor

marcellofuschi commented Jul 13, 2020 •
edited
Loading

Internal link: link pointing to another spot in the same document instead of an external URL.

I noticed that the official link plugin doesn't properly handle internal links by default. For example, when you click on an existing internal link it tries to open it in a new tab (target=_blank behavior).
@marcellofuschi marcellofuschi added the type:task This issue reports a chore (non-production change) and other types of "todos". label Jul 13, 2020
@Reinmar
Copy link
Member

Reinmar commented Aug 10, 2020

Hi! Do you mean anchor links #some-anchor? You'd expect that when clicking such a link you get scrolled to this point in the document?

@Reinmar Reinmar added domain:ui/ux This issue reports a problem related to UI or UX. package:link squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature. and removed type:task This issue reports a chore (non-production change) and other types of "todos". labels Aug 10, 2020
@Reinmar Reinmar added this to the backlog milestone Aug 10, 2020
@marcellofuschi
Copy link
Contributor Author

Hi! Yes, that's what I would expect.

@pomek pomek removed this from the backlog milestone Feb 21, 2022
@jswiderski jswiderski added the resolution:duplicate This issue is a duplicate of another issue and was merged into it. label May 2, 2022
@jswiderski
Copy link

Duplicate of #1944.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:link resolution:duplicate This issue is a duplicate of another issue and was merged into it. squad:core Issue to be handled by the Core team. type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Reinmar @pomek @jswiderski @marcellofuschi