Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IndentBlock should work with config.heading.options #5565

Closed
oleq opened this issue Oct 10, 2019 · 3 comments
Closed

IndentBlock should work with config.heading.options #5565

oleq opened this issue Oct 10, 2019 · 3 comments
Labels
package:indent resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.

Comments

@oleq
Copy link
Member

oleq commented Oct 10, 2019

📝 Provide detailed reproduction steps (if any)

ATM block names in the model are hardcoded. If anyone configures different heading element names, the block indent will stop working.

Since ckeditor/ckeditor5-indent#20 delays the initialization of the indent block feature, we can discover heading element names as I mentioned in the PR.

cc @jodator


If you'd like to see this fixed sooner, add a 👍 reaction to this post.

@oleq oleq added the type:bug This issue reports a buggy (incorrect) behavior. label Oct 10, 2019
@jodator
Copy link
Contributor

jodator commented Oct 10, 2019

As in the PR comments: Yep, the refined code for this looks cool and as long we will not change the heading configuration options API then we will be safe with this change.

@mlewand mlewand added this to the backlog milestone Nov 4, 2019
@pomek pomek removed this from the backlog milestone Feb 21, 2022
@CKEditorBot
Copy link
Collaborator

There has been no activity on this issue for the past year. We've marked it as stale and will close it in 30 days. We understand it may be relevant, so if you're interested in the solution, leave a comment or reaction under this issue.

@CKEditorBot
Copy link
Collaborator

We've closed your issue due to inactivity over the last year. We understand that the issue may still be relevant. If so, feel free to open a new one (and link this issue to it).

@CKEditorBot CKEditorBot added the resolution:expired This issue was closed due to lack of feedback. label Nov 5, 2023
@CKEditorBot CKEditorBot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:indent resolution:expired This issue was closed due to lack of feedback. status:stale type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

6 participants