Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added tabindex support to the InputBase class #16025

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Added tabindex support to the InputBase class #16025

merged 5 commits into from
Mar 18, 2024

Conversation

Mati365
Copy link
Member

@Mati365 Mati365 commented Mar 14, 2024 •
edited
Loading

Suggested merge commit message (convention)

internal (pagination): Add tab-index attribute to InputBase. Closes https://github.com/cksource/ckeditor5-commercial/issues/6032.

@Mati365 Mati365 requested review from oleq and DawidKossowski March 14, 2024 07:06
oleq
oleq requested changes Mar 18, 2024
View reviewed changes
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing unit tests.

@Mati365 Mati365 requested a review from oleq March 18, 2024 13:24
@oleq oleq changed the title Fix incorrect focus order in pagination Added tabindex support to the InputBase class Mar 18, 2024
@oleq oleq merged commit 5a39981 into master Mar 18, 2024
6 checks passed
@oleq oleq deleted the ck/6032 branch March 18, 2024 14:05
@CKEditorBot CKEditorBot mentioned this pull request Mar 19, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DawidKossowski DawidKossowski Awaiting requested review from DawidKossowski

@oleq oleq Awaiting requested review from oleq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mati365 @oleq