From 3b062a3ae6cf96582fc74c75d68ee40ac2a155a1 Mon Sep 17 00:00:00 2001 From: Arkadiusz Filipczak Date: Tue, 7 Sep 2021 14:58:53 +0200 Subject: [PATCH 1/2] Add windowtext to allowed colros --- packages/ckeditor5-engine/src/view/styles/utils.js | 2 ++ packages/ckeditor5-engine/tests/view/styles/utils.js | 2 ++ 2 files changed, 4 insertions(+) diff --git a/packages/ckeditor5-engine/src/view/styles/utils.js b/packages/ckeditor5-engine/src/view/styles/utils.js index af8a463778f..f7b291579f5 100644 --- a/packages/ckeditor5-engine/src/view/styles/utils.js +++ b/packages/ckeditor5-engine/src/view/styles/utils.js @@ -36,6 +36,8 @@ const COLOR_NAMES = new Set( [ 'papayawhip', 'peachpuff', 'peru', 'pink', 'plum', 'powderblue', 'rosybrown', 'royalblue', 'saddlebrown', 'salmon', 'sandybrown', 'seagreen', 'seashell', 'sienna', 'skyblue', 'slateblue', 'slategray', 'slategrey', 'snow', 'springgreen', 'steelblue', 'tan', 'thistle', 'tomato', 'turquoise', 'violet', 'wheat', 'whitesmoke', 'yellowgreen', + // CSS Color Module Level 3 (System Colors) + 'windowtext', // CSS Color Module Level 4 'rebeccapurple', // Keywords diff --git a/packages/ckeditor5-engine/tests/view/styles/utils.js b/packages/ckeditor5-engine/tests/view/styles/utils.js index 66c229507a7..f38de73abbc 100644 --- a/packages/ckeditor5-engine/tests/view/styles/utils.js +++ b/packages/ckeditor5-engine/tests/view/styles/utils.js @@ -126,6 +126,8 @@ describe( 'Styles utils', () => { 'orange', // CSS Level 3 'cyan', 'azure', 'wheat', + // CSS Level 3 System Colors + 'windowtext', // CSS Level 4 'rebeccapurple' ], isColor ); From 7b1ecbbc9840b672ce27a0ecff6c7bf26ee37ab1 Mon Sep 17 00:00:00 2001 From: Arkadiusz Filipczak Date: Wed, 8 Sep 2021 09:27:27 +0200 Subject: [PATCH 2/2] Add other system colors to allowed colros --- packages/ckeditor5-engine/src/view/styles/utils.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/ckeditor5-engine/src/view/styles/utils.js b/packages/ckeditor5-engine/src/view/styles/utils.js index f7b291579f5..12e64628b83 100644 --- a/packages/ckeditor5-engine/src/view/styles/utils.js +++ b/packages/ckeditor5-engine/src/view/styles/utils.js @@ -37,7 +37,10 @@ const COLOR_NAMES = new Set( [ 'sandybrown', 'seagreen', 'seashell', 'sienna', 'skyblue', 'slateblue', 'slategray', 'slategrey', 'snow', 'springgreen', 'steelblue', 'tan', 'thistle', 'tomato', 'turquoise', 'violet', 'wheat', 'whitesmoke', 'yellowgreen', // CSS Color Module Level 3 (System Colors) - 'windowtext', + 'activeborder', 'activecaption', 'appworkspace', 'background', 'buttonface', 'buttonhighlight', 'buttonshadow', + 'buttontext', 'captiontext', 'graytext', 'highlight', 'highlighttext', 'inactiveborder', 'inactivecaption', + 'inactivecaptiontext', 'infobackground', 'infotext', 'menu', 'menutext', 'scrollbar', 'threeddarkshadow', + 'threedface', 'threedhighlight', 'threedlightshadow', 'threedshadow', 'window', 'windowframe', 'windowtext', // CSS Color Module Level 4 'rebeccapurple', // Keywords