From 8052dd8494cd9ba3cce4d32d362cde3c10d2db2c Mon Sep 17 00:00:00 2001 From: Aleksander Nowodzinski Date: Tue, 19 Mar 2024 14:54:19 +0100 Subject: [PATCH 1/2] Other (core): Clarified the accessibility help dialog description for the keystroke that executes buttons. --- packages/ckeditor5-core/lang/contexts.json | 2 +- packages/ckeditor5-core/src/accessibility.ts | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/ckeditor5-core/lang/contexts.json b/packages/ckeditor5-core/lang/contexts.json index 30809fc0135..0c8d87cf314 100644 --- a/packages/ckeditor5-core/lang/contexts.json +++ b/packages/ckeditor5-core/lang/contexts.json @@ -23,5 +23,5 @@ "Move focus between form fields (inputs, buttons, etc.)": "Keystroke description for assistive technologies: keystroke for moving between fields.", "Move focus to the toolbar, navigate between toolbars": "Keystroke description for assistive technologies: keystroke for moving focus to the toolbar.", "Navigate through the toolbar": "Keystroke description for assistive technologies: keystroke for navigating through the toolbar.", - "Execute the currently focused button": "Keystroke description for assistive technologies: keystroke for executing currently focused button." + "Execute the currently focused button. Executing buttons that interact with the editor content moves the focus back to the content.": "Keystroke description for assistive technologies: keystroke for executing currently focused button." } diff --git a/packages/ckeditor5-core/src/accessibility.ts b/packages/ckeditor5-core/src/accessibility.ts index c8a08d33f96..c5fc0d63c61 100644 --- a/packages/ckeditor5-core/src/accessibility.ts +++ b/packages/ckeditor5-core/src/accessibility.ts @@ -91,7 +91,8 @@ export default class Accessibility { keystroke: [ [ 'arrowup' ], [ 'arrowright' ], [ 'arrowdown' ], [ 'arrowleft' ] ] }, { - label: t( 'Execute the currently focused button' ), + // eslint-disable-next-line max-len + label: t( 'Execute the currently focused button. Executing buttons that interact with the editor content moves the focus back to the content.' ), keystroke: [ [ 'Enter' ], [ 'Space' ] ] } ] From f6a7251375593ea9b5a0e10496ced0b732c63eaa Mon Sep 17 00:00:00 2001 From: Aleksander Nowodzinski Date: Tue, 19 Mar 2024 15:21:12 +0100 Subject: [PATCH 2/2] Tests: Updated the accessibility keystroke label in a unit test. --- packages/ckeditor5-core/tests/accessibility.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/ckeditor5-core/tests/accessibility.js b/packages/ckeditor5-core/tests/accessibility.js index 068c51b8a3c..1d2d1b49f3c 100644 --- a/packages/ckeditor5-core/tests/accessibility.js +++ b/packages/ckeditor5-core/tests/accessibility.js @@ -80,7 +80,8 @@ describe( 'Accessibility', () => { [ 'Enter' ], [ 'Space' ] ], - label: 'Execute the currently focused button' + // eslint-disable-next-line max-len + label: 'Execute the currently focused button. Executing buttons that interact with the editor content moves the focus back to the content.' } ], label: undefined