Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification title #5366

Closed
szymonkups opened this issue Jun 1, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-ui#242
Closed

Notification title #5366

szymonkups opened this issue Jun 1, 2017 · 1 comment · Fixed by ckeditor/ckeditor5-ui#242
Assignees
@szymonkups
Labels
package:ui status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Milestone
iteration 11

Comments

@szymonkups
Copy link
Contributor

Notification's could have optional title, added to data https://github.com/ckeditor/ckeditor5-ui/blob/master/src/notification/notification.js#L60.
@szymonkups szymonkups self-assigned this Jun 1, 2017
@oskarwrobel
Copy link
Contributor

This could be additional property or the same property with specific format like

Notification Title|Notification content.

Maybe | is not the best option for separator but it could be anything.

pjasiun referenced this issue in ckeditor/ckeditor5-ui Jun 1, 2017
Merge pull request #242 from ckeditor/t/241
abbb68f 
Feature: Added optional notification title. Closes #241.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-ui Oct 9, 2019
@mlewand mlewand added this to the iteration 11 milestone Oct 9, 2019
@mlewand mlewand added status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option). package:ui labels Oct 9, 2019
@szymonkups szymonkups mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@szymonkups szymonkups

Labels
package:ui status:discussion type:feature This issue reports a feature request (an idea for a new functionality or a missing option).
Projects
None yet
Milestone
iteration 11
Development

Successfully merging a pull request may close this issue.

Optional notification title ckeditor/ckeditor5-ui
3 participants
@oskarwrobel @szymonkups @mlewand