Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style only drodpown toolbar buttons with text. #3389

Closed
jodator opened this issue Jan 12, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-theme-lark#121
Closed

Style only drodpown toolbar buttons with text. #3389

jodator opened this issue Jan 12, 2018 · 1 comment · Fixed by ckeditor/ckeditor5-theme-lark#121

Comments

@jodator
Copy link
Contributor

jodator commented Jan 12, 2018

Right now every "dropdown button" in toolbar gets border and bakcground (like the heading dropdown) and adding type of dropdowns required to add exceptions to that CSS rules in theme.

I think that's better to not add those visual styles to dropdown buttons but instead to only style those "with text" (as in heading dropdown case).
@jodator
Copy link
Contributor Author

jodator commented Jan 12, 2018

This is a continuation from: https://github.com/ckeditor/ckeditor5-ui/issues/358#issuecomment-357205752 as it does not make sense to create new classes. Use existing CSS classes instead.

Reinmar referenced this issue in ckeditor/ckeditor5-theme-lark Jan 15, 2018
@Reinmar
Merge pull request #121 from ckeditor/t/ckeditor5-font/4
93338a5 
Other: Style `ck-button_with-text` instead of styling every dropdown button in toolbar. Closes #122.
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-theme-lark Oct 9, 2019
@jodator jodator mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@jodator