Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Todo list + RTL support #3017

Closed
pjasiun opened this issue Aug 9, 2019 · 5 comments
Closed

Todo list + RTL support #3017

pjasiun opened this issue Aug 9, 2019 · 5 comments
Assignees
@oleq
Labels
package:list type:improvement This issue reports a possible enhancement of an existing feature.
Milestone
iteration 27 (v15...

Comments

@pjasiun
Copy link

pjasiun commented Aug 9, 2019

In RTL you use opposite arrows to move between list items, so most probably we should check and fix how selection jump over UI elements in todo lists in RTL.
@oleq
Copy link
Member

oleq commented Aug 13, 2019

Is this related https://github.com/ckeditor/ckeditor5-widget/issues/97?

@pjasiun
Copy link
Author

pjasiun commented Aug 13, 2019

Kind of. I do not think it is directly connected, because todo has its own implementation of arrows handling, but the problem is similar.

@Reinmar
Copy link
Member

Reinmar commented Aug 27, 2019 •
edited
Loading

I'm assigning this to it27 because it seems that it can be fixed together with https://github.com/ckeditor/ckeditor5-widget/issues/97. If not, we can postpone this one.

@AnnaTomanek
Copy link
Contributor

AnnaTomanek commented Aug 29, 2019 •
edited by dkonopka
Loading

FYI, another issue that we encountered when working on the screenshot for the release blog post was this:

Screenshot 2019-08-29 at 13 41 30

@dkonopka provided some quick fixes for this in 43d99ee.

oleq referenced this issue in ckeditor/ckeditor5-theme-lark Sep 19, 2019
@oleq
Fix: Fixed broken to-do list layout in RTL content (see ckeditor/cked…
7e7d268 
…itor5-list#134).
jodator referenced this issue in ckeditor/ckeditor5-list Sep 20, 2019
@jodator
Merge pull request #155 from ckeditor/t/134
63deb51 
Fix: Keyboard navigation should work inside to-do lists in RTL content (see ckeditor/ckeditor5-list#134).
@jodator
Copy link
Contributor

jodator commented Sep 20, 2019

Closed by 63deb51.

@jodator jodator closed this as completed Sep 20, 2019
@mlewand mlewand transferred this issue from ckeditor/ckeditor5-list Oct 9, 2019
@mlewand mlewand added this to the iteration 27 milestone Oct 9, 2019
@mlewand mlewand added status:confirmed type:improvement This issue reports a possible enhancement of an existing feature. package:list labels Oct 9, 2019
@oleq oleq mentioned this issue Oct 11, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleq oleq

Labels
package:list type:improvement This issue reports a possible enhancement of an existing feature.
Projects
None yet
Milestone
iteration 27 (v15.0.0)
Development

No branches or pull requests
6 participants
@Reinmar @jodator @AnnaTomanek @oleq @pjasiun @mlewand