Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Boolean Attributes (like required) not correctly recognized by form dialogs #586

Closed
f1ames opened this issue Jun 30, 2017 · 2 comments
Closed

Boolean Attributes (like required) not correctly recognized by form dialogs #586

f1ames opened this issue Jun 30, 2017 · 2 comments
Assignees
@engineering-this
Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Milestone
4.11.0

Comments

@f1ames
Copy link
Contributor

f1ames commented Jun 30, 2017

Are you reporting a feature or a bug?

Bug

Check if the issue is already reported

http://dev.ckeditor.com/ticket/14291

Provide detailed reproduction steps (if any)

  1. Go to http://sdk.ckeditor.com/samples/fullpreset.html.
  2. Open Source mode and replace content with <input checked required type="checkbox" />.
  3. Switch back to WYSIWYG mode.
  4. Double click on checkbox to open dialog.

Expected result

Dialog should show that the input is required (required option checked).

Actual result

The required option is not checked.

Other details

  • Browser: All
  • OS: All
  • CKEditor version: 4.7.1
  • Installed CKEditor plugins: Full preset

The cause of the issue is described here http://dev.ckeditor.com/ticket/14291#comment:2.
@f1ames f1ames added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. type:bug A bug. labels Jun 30, 2017
@f1ames f1ames mentioned this issue Jun 30, 2017
Closed
2 tasks
@Comandeer Comandeer mentioned this issue Jun 30, 2017
Closed
2 tasks
@f1ames f1ames changed the title Boolean Attributes (like required) not correctly recognized by form dialogs. Boolean Attributes (like required) not correctly recognized by form dialogs Jul 5, 2017
@mlewand mlewand added the target:minor Any docs related issue that can be merged into a master or major branch. label Jan 3, 2018
@engineering-this engineering-this mentioned this issue Jan 9, 2018
Merged
2 tasks
@engineering-this engineering-this self-assigned this Aug 31, 2018
@Comandeer Comandeer added this to the 4.10.2 milestone Sep 5, 2018
@Comandeer
Copy link
Member

Merged into 4.10.2 branch.

@mlewand
Copy link
Contributor

mlewand commented Sep 5, 2018

Note that you can already have a peek at the working solution in our nightly preview 😉

@mlewand mlewand modified the milestones: 4.10.2, 4.11.0 Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@engineering-this engineering-this

Labels
good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. status:confirmed An issue confirmed by the development team. target:minor Any docs related issue that can be merged into a master or major branch. type:bug A bug.
Projects
None yet
Milestone
4.11.0
Development

No branches or pull requests
4 participants
@f1ames @Comandeer @mlewand @engineering-this