Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus goes to editor when closing a dialog using "escape" key #5147

Closed
kpasagada opened this issue Apr 5, 2022 · 3 comments · Fixed by #5260
Closed

Focus goes to editor when closing a dialog using "escape" key #5147

kpasagada opened this issue Apr 5, 2022 · 3 comments · Fixed by #5260
Assignees
Labels
accessibility Issue related to accessibility. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@kpasagada
Copy link

Type of report

Bug (accessibility issue)

Provide detailed reproduction steps (if any)

  1. Place cursor inside the editor
  2. Tab to the toolbar (using Alt+F10 on windows) and tab to the "link" button
  3. Hit enter on "link" button for the link dialog to open
  4. Press "escape" key to close the dialog
  5. Notice that the focus goes to the editor instead of the link button

Expected result

Focus should go back to the link button.
image

Actual result

Focus goes back into the editor which is an accessibility issue for keyboard users. This can be observed on the CK Editor 4 demo page. https://ckeditor.com/ckeditor-4/demo/

Other details

  • Browser: Chrome 99.0.4844.84
  • OS: Windows 11
  • CKEditor version: 4.17.1
  • Installed CKEditor plugins: Full preset
@kpasagada kpasagada added the type:bug A bug. label Apr 5, 2022
@Comandeer
Copy link
Member

It's a similar case to the #4783 one. We decided then to add appropriate info into our accessibility help dialog. Probably the information about the focus change after closing dialogs should also be added to the dialog.

@Comandeer Comandeer added status:confirmed An issue confirmed by the development team. accessibility Issue related to accessibility. size:XS labels Apr 5, 2022
@kpasagada
Copy link
Author

Agreed, this one can be fixed with similar information in the a11y help plugin under the editor dialog section.

@CKEditorBot
Copy link
Collaborator

Closed in #5260

@CKEditorBot CKEditorBot added this to the 4.19.1 milestone Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants