Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to abandon editor delayed creation #4641

Closed
sculpt0r opened this issue Apr 26, 2021 · 3 comments · Fixed by #5133
Closed

Allow to abandon editor delayed creation #4641

sculpt0r opened this issue Apr 26, 2021 · 3 comments · Fixed by #5133
Assignees
@sculpt0r
Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone
4.19.0

Comments

@sculpt0r
Copy link
Contributor

Type of report

Task

Provide detailed reproduction steps (if any)

Follow up from #4463 , based on #4463 (review), #4463 (comment),

We should introduce logic, which allows the User to break interval checks whenever User decides to abandon editor creation.

Expected result

What is the expected result of the above steps?

Actual result

What is the actual result of the above steps?

Other details

  • Browser: -
  • OS: -
  • CKEditor version: -
  • Installed CKEditor plugins: -
@sculpt0r sculpt0r added type:task Any other issue (refactoring, typo fix, etc). status:confirmed An issue confirmed by the development team. core The issue is caused by the editor core code. size:S labels Apr 26, 2021
@sculpt0r sculpt0r mentioned this issue Apr 26, 2021
Merged
3 tasks
@jacekbogdanski jacekbogdanski changed the title Allow to abandon editor delayed creation. Allow to abandon editor delayed creation Dec 7, 2021
@jacekbogdanski jacekbogdanski added type:feature A feature request. and removed type:task Any other issue (refactoring, typo fix, etc). labels Dec 7, 2021
@jacekbogdanski
Copy link
Member

Note that this feature should be also implemented in Vue and Angular integrations to avoid memory leaks.

@jacekbogdanski
Copy link
Member

Let's also cover #5030 with this ticket.

@sculpt0r sculpt0r self-assigned this Mar 21, 2022
@sculpt0r sculpt0r mentioned this issue Mar 22, 2022
Merged
3 tasks
@CKEditorBot
Copy link
Collaborator

Closed in #5133

@CKEditorBot CKEditorBot added this to the 4.19.0 milestone Apr 27, 2022
This was referenced Apr 27, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sculpt0r sculpt0r

Labels
core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Milestone
4.19.0
Development

Successfully merging a pull request may close this issue.

Add functionality to cancel awaiting for delayed editor creation ckeditor/ckeditor4
3 participants
@sculpt0r @jacekbogdanski @CKEditorBot