Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple mentions causes keyboard navigation issues #4107

Closed
f1ames opened this issue Jun 12, 2020 · 1 comment
Closed

Multiple mentions causes keyboard navigation issues #4107

f1ames opened this issue Jun 12, 2020 · 1 comment
Assignees
@jacekbogdanski
Labels
plugin:mentions The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.15.0

Comments

@f1ames
Copy link
Contributor

f1ames commented Jun 12, 2020

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Add sourcearea plugin to tests/plugins/mentions/manual/mentions test.
  2. Go to http://localhost:1030/tests/plugins/mentions/manual/mentions.
  3. Switch editor to source mode and back.
  4. Type $ or #.
  5. Navigate with down/up arrow key through suggestions.

Expected result

It's possible to navigate through panel.

Actual result

It's not possible to navigate through panel.

Other details

From what I have checked, the listeners are correctly attached and model/view also correctly updated. However, it seems the suggestions panel DOM element is incorrect (because there are 3 for each mentions instance) and thus not being updated. I'm not 100% sure if that's what exactly happens because I did only quick check here.

  • Browser: All
  • OS: All
  • CKEditor version: 4.12.1 (the oldest one I checked), 4.14.1
  • Installed CKEditor plugins: mentions
@f1ames f1ames added type:bug A bug. status:confirmed An issue confirmed by the development team. plugin:mentions The plugin which probably causes the issue. workload:medium labels Jun 12, 2020
@jacekbogdanski jacekbogdanski self-assigned this Jun 22, 2020
@jacekbogdanski jacekbogdanski mentioned this issue Jun 22, 2020
Merged
3 tasks
@Dumluregn Dumluregn mentioned this issue Jun 24, 2020
Closed
@Dumluregn
Copy link
Contributor

Closed in 21b24d9.

@f1ames f1ames added this to the 4.15.0 milestone Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacekbogdanski jacekbogdanski

Labels
plugin:mentions The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.15.0
Development

No branches or pull requests
3 participants
@f1ames @jacekbogdanski @Dumluregn