Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Format button no longer works when no text is selected #4008

Closed
murat-amazon opened this issue Apr 28, 2020 · 2 comments
Closed

Remove Format button no longer works when no text is selected #4008

murat-amazon opened this issue Apr 28, 2020 · 2 comments
Assignees
Labels
plugin:removeformat The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone

Comments

@murat-amazon
Copy link

Type of report

Bug

Provide detailed reproduction steps (if any)

  1. Load the editor version 4.14.0: https://jsfiddle.net/xda4omnr/1/
  2. Select "bold" and "underlined"
  3. Type: Hello,
  4. Click "Remove Format" button
  5. Type: world!

Expected result

The text world! has normal style.

Actual result

The text world! is bold and underlined.

Other details

This feature used to work before - up to and including version 4.11.1. See https://jsfiddle.net/xda4omnr/2/ where the feature works.

The culprit which introduced the regression is most likely this commit: 4a29296

Note that you can still remove formatting after selecting some text, but some users use this button just to reset their styling from a particular moment on without selecting any text.

  • Browser: Chrome
  • OS: Mac OS
  • CKEditor version: 4.14.0
  • Installed CKEditor plugins: full/all
@murat-amazon murat-amazon added the type:bug A bug. label Apr 28, 2020
@Dumluregn Dumluregn added plugin:removeformat The plugin which probably causes the issue. status:confirmed An issue confirmed by the development team. labels Apr 28, 2020
@Dumluregn
Copy link
Contributor

Hello, thank you for very thorough research on this issue! Unfortunately I can confirm this behaviour.

@Comandeer
Copy link
Member

Merged in 453880, will be released in 4.14.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plugin:removeformat The plugin which probably causes the issue. regression This issue is a regression. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Development

No branches or pull requests

5 participants