Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double click on one word span produces buggy selection #3161

Closed
engineering-this opened this issue Jun 13, 2019 · 2 comments · Fixed by #3213
Closed

Double click on one word span produces buggy selection #3161

engineering-this opened this issue Jun 13, 2019 · 2 comments · Fixed by #3213
Assignees
Labels
browser:firefox The issue can only be reproduced in the Firefox browser. browser:ie11 The issue can only be reproduced in the Internet Explorer 11 browser. core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Milestone

Comments

@engineering-this
Copy link
Contributor

Type of report

Feature

Provide detailed reproduction steps (if any)

  1. Once t/2813 ( Fix for: editor.insertHtml and editor.insertElement pollutes editable with empty spans #2987) is merged open manual test tests/core/editable/manual/insert
  2. Place collapsed selection in the middle of one spans Foo ^bar.
  3. Press insert element.
  4. Double click on created bar span.
  5. Press insert element

Expected result

Span containing word bar is completely removed.

Actual result

Span is preserved only it's text is removed.

Other details

This is an upstream browser issue, so it is labeled as a feature to provide a workaround. To fix this we should introduce logic to optimize selection, which would also fix #3118.

  • Browser: Firefox
  • OS: macOS
  • CKEditor version: development of 4.12.0
  • Installed CKEditor plugins: …
@engineering-this engineering-this added type:feature A feature request. status:confirmed An issue confirmed by the development team. browser:firefox The issue can only be reproduced in the Firefox browser. labels Jun 13, 2019
@engineering-this engineering-this self-assigned this Jun 13, 2019
@f1ames f1ames added browser:ie11 The issue can only be reproduced in the Internet Explorer 11 browser. core The issue is caused by the editor core code. labels Jun 14, 2019
@f1ames
Copy link
Contributor

f1ames commented Jun 14, 2019

As mentioned in #2987 (review) it also happens in IE11 (other IEs should be also checked when working on the bug fix).

@f1ames
Copy link
Contributor

f1ames commented Jun 17, 2019

Extracted from #2987 - there is a wider issue, similar also to #3118. It is caused as @engineering-this mentioned by specific selection which begins on the current node but ends on the beginning of the next one (which is not visible). On IE11 it occurs also with mouse selection:

ie11 issue

And also in any other browser similarly:

all issue

I think we need proper Umbrella ticket for this issue, I will create it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
browser:firefox The issue can only be reproduced in the Firefox browser. browser:ie11 The issue can only be reproduced in the Internet Explorer 11 browser. core The issue is caused by the editor core code. status:confirmed An issue confirmed by the development team. type:feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants