Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for memory leaks #2977

Open
f1ames opened this issue Mar 25, 2019 · 0 comments
Open

Add unit tests for memory leaks #2977

f1ames opened this issue Mar 25, 2019 · 0 comments
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).

Comments

@f1ames
Copy link
Contributor

f1ames commented Mar 25, 2019

Type of report

Task

Provide description of the task

Since #589 is covered in #2969 and should be close soon we may think about introducing unit tests for checking memory leaks.

It could be done as a part of regular tests (however, I'm not sure if it will be easy to integrate with bender properly) or just as a standalone tests running only on CI (maybe using our memory testing tool).

Similar tests were introduced in CKEditor 5 in ckeditor/ckeditor5-core#155.
@f1ames f1ames added the type:task Any other issue (refactoring, typo fix, etc). label Mar 25, 2019
@jacekbogdanski jacekbogdanski added the status:confirmed An issue confirmed by the development team. label Mar 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status:confirmed An issue confirmed by the development team. type:task Any other issue (refactoring, typo fix, etc).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@f1ames @jacekbogdanski