Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose toggle buttons in accessibility tree #2444

Closed
Comandeer opened this issue Sep 29, 2018 · 1 comment · Fixed by #5123
Closed

Expose toggle buttons in accessibility tree #2444

Comandeer opened this issue Sep 29, 2018 · 1 comment · Fixed by #5123
Assignees
Labels
accessibility Issue related to accessibility. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:feature A feature request.
Milestone

Comments

@Comandeer
Copy link
Member

Type of report

Feature request

Provide description of the new feature

There are many toggle buttons inside editor's toolbar, e.g. "Bold", "Italic", "Underline" etc. To correctly expose them as toggle buttons in a11y tree, they must have [role=button] and [aria-pressed] attribute.

Default state:

<a href="#" role="button" aria-pressed="false">Bold</a>

Toggled/pressed state:

<a href="#" role="button" aria-pressed="true">Bold</a>

However we don't add [aria-pressed=false] for not-pressed buttons, as we do not distinguish between ordinary buttons and toggle ones. We only add [aria-pressed=true] when toggle buttons are activated. We could introduce the new toggle button category, which will always have [aria-pressed] attribute, removing handling of this attribute from ordinary buttons at the same time.

@Comandeer Comandeer added type:feature A feature request. status:confirmed An issue confirmed by the development team. accessibility Issue related to accessibility. labels Sep 29, 2018
@mlewand mlewand added the target:major Any docs related issue that should be merged into a major branch. label Oct 1, 2018
@f1ames f1ames added support An issue reported by a commercially licensed client. support:2 An issue reported by a commercially licensed client. and removed support An issue reported by a commercially licensed client. labels Sep 18, 2019
@f1ames f1ames removed the target:major Any docs related issue that should be merged into a major branch. label Nov 12, 2019
@CKEditorBot
Copy link
Collaborator

Closed in #5123

@CKEditorBot CKEditorBot added this to the 4.19.0 milestone Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility Issue related to accessibility. status:confirmed An issue confirmed by the development team. support:2 An issue reported by a commercially licensed client. type:feature A feature request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants