Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readonly editors incorrectly marked up for Assistive Technology #1904

Closed
Comandeer opened this issue Apr 19, 2018 · 4 comments · Fixed by #5146
Closed

Readonly editors incorrectly marked up for Assistive Technology #1904

Comandeer opened this issue Apr 19, 2018 · 4 comments · Fixed by #5146
Assignees
@Comandeer
Labels
accessibility Issue related to accessibility. status:confirmed An issue confirmed by the development team. type:bug A bug.
Milestone
4.19.0

Comments

@Comandeer
Copy link
Member

Are you reporting a feature request or a bug?

Bug

Provide detailed reproduction steps (if any)

  1. Open example of readonly editor, e.g. https://jsfiddle.net/sjg91czp/

Expected result

Editor's editable has [aria-readonly=true] attribute attached.

Actual result

There is no such attribute.

Other details

  • CKEditor version: 4.9.1
@Comandeer Comandeer added type:bug A bug. status:confirmed An issue confirmed by the development team. accessibility Issue related to accessibility. labels Apr 19, 2018
@mlewand mlewand added good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. target:minor Any docs related issue that can be merged into a master or major branch. labels Apr 19, 2018
@Comandeer Comandeer self-assigned this Sep 29, 2018
@Comandeer Comandeer mentioned this issue Sep 29, 2018
Closed
2 tasks
@mgifford
Copy link

Also reported in Drupal 8 - https://www.drupal.org/project/drupal/issues/2999131

@mgifford
Copy link

Also probably just need good old HTML here - https://tink.uk/screen-reader-support-for-disabled-read-only-form-fields/

@mlewand
Copy link
Contributor

mlewand commented Oct 21, 2018

@mgifford [disabled] won't do the trick in this case as we're using either a div or body with [contenteditable] and disabled is not supported for these. Proposed aria-readonly should do the trick.

@f1ames f1ames mentioned this issue Jul 11, 2019
Closed
@f1ames f1ames removed the target:minor Any docs related issue that can be merged into a master or major branch. label Nov 12, 2019
@Comandeer Comandeer mentioned this issue May 21, 2020
Closed
@Comandeer Comandeer added workload:medium and removed good first issue Relatively easy to fix. This is a perfect issue if you are willing to create a Pull Request. labels May 21, 2020
@Comandeer Comandeer mentioned this issue Apr 3, 2022
Merged
3 tasks
@CKEditorBot CKEditorBot added this to the 4.18.1 milestone May 9, 2022
@CKEditorBot
Copy link
Collaborator

Closed in #5146

@jacekbogdanski jacekbogdanski modified the milestones: 4.18.1, 4.19.0 May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Comandeer Comandeer

Labels
accessibility Issue related to accessibility. status:confirmed An issue confirmed by the development team. type:bug A bug.
Projects
None yet
Milestone
4.19.0
Development

Successfully merging a pull request may close this issue.

Tweaks for representation of the editor in the accessibility tree ckeditor/ckeditor4
6 participants
@mgifford @f1ames @Comandeer @mlewand @jacekbogdanski @CKEditorBot